Re: [PR] HttpShardHandler: Fix extension hook transformResponse [solr]

2024-09-23 Thread via GitHub
dsmiley commented on PR #2661: URL: https://github.com/apache/solr/pull/2661#issuecomment-2369101061 it's about a trivial change as changes go. Users (and I count myself as impacted at work BTW) would find out upon upgrading. Tons of other changes happen without CHANGES.txt prescribing ev

Re: [PR] HttpShardHandler: Fix extension hook transformResponse [solr]

2024-09-23 Thread via GitHub
fsparv commented on PR #2661: URL: https://github.com/apache/solr/pull/2661#issuecomment-2368855403 If users have implemented a custom handler (as is clearly implied via the doc on the method, and it's no-op default implementation) their code would need to be updated and rebuilt. Seems like

Re: [PR] HttpShardHandler: Fix extension hook transformResponse [solr]

2024-09-23 Thread via GitHub
dsmiley commented on PR #2661: URL: https://github.com/apache/solr/pull/2661#issuecomment-2368533696 Renaming a protected method doesn't deserve a JIRA and wasting readers time to read about it in CHANGES.txt. -- This is an automated message from the Apache Git Service. To respond to the

Re: [PR] HttpShardHandler: Fix extension hook transformResponse [solr]

2024-09-22 Thread via GitHub
gus-asf commented on PR #2661: URL: https://github.com/apache/solr/pull/2661#issuecomment-2366952387 > Also the spelling error in the method should be fixed... transfomResponse -> transformResponse. I suppose that has to be a 10x only change since it's an extension point. (I can do b

Re: [PR] HttpShardHandler: Fix extension hook transformResponse [solr]

2024-09-22 Thread via GitHub
gus-asf commented on PR #2661: URL: https://github.com/apache/solr/pull/2661#issuecomment-2366945531 Also the spelling error in the method should be fixed... transfomResponse -> transformResponse. I suppose that has to be a 10x only change since it's an extension point. -- This is an aut

Re: [PR] HttpShardHandler: Fix extension hook transformResponse [solr]

2024-08-26 Thread via GitHub
dsmiley merged PR #2661: URL: https://github.com/apache/solr/pull/2661 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.or