dsmiley merged PR #2419:
URL: https://github.com/apache/solr/pull/2419
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.or
uschindler commented on code in PR #2419:
URL: https://github.com/apache/solr/pull/2419#discussion_r1605999741
##
gradlew.bat:
##
@@ -87,7 +89,7 @@ set CLASSPATH=%GRADLE_WRAPPER_JAR%
IF NOT EXIST "%APP_HOME%\gradle.properties" (
@rem local expansion is needed to check ERRORL
dsmiley commented on PR #2419:
URL: https://github.com/apache/solr/pull/2419#issuecomment-2119087912
I forgot the Windows one; I'm glad I tagged you for review :-) Maybe you
could review that?
Admittedly the --source issue was specific to a custom JVM variant where I
work. Maybe --
uschindler commented on PR #2419:
URL: https://github.com/apache/solr/pull/2419#issuecomment-2118882070
Could we have that for Windows, too.
I don't know what your exact problem with '--source 11' was. Basically it
would be better to use `--release 11` then it works correctly. The mai
dsmiley commented on PR #2419:
URL: https://github.com/apache/solr/pull/2419#issuecomment-2116609994
I'll merge this in a couple days if I don't hear back.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above