Re: [PR] Actually make collections PRS enabled in tests [solr]

2025-03-01 Thread via GitHub
github-actions[bot] commented on PR #2824: URL: https://github.com/apache/solr/pull/2824#issuecomment-2692476811 This PR is now closed due to 60 days of inactivity after being marked as stale. Re-opening this PR is still possible, in which case it will be marked as active again. -- This

Re: [PR] Actually make collections PRS enabled in tests [solr]

2025-03-01 Thread via GitHub
github-actions[bot] closed pull request #2824: Actually make collections PRS enabled in tests URL: https://github.com/apache/solr/pull/2824 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specif

Re: [PR] Actually make collections PRS enabled in tests [solr]

2024-12-30 Thread via GitHub
github-actions[bot] commented on PR #2824: URL: https://github.com/apache/solr/pull/2824#issuecomment-2566019328 This PR has had no activity for 60 days and is now labeled as stale. Any new activity will remove the stale label. To attract more reviewers, please tag people who might be fam

Re: [PR] Actually make collections PRS enabled in tests [solr]

2024-10-31 Thread via GitHub
dsmiley commented on PR #2824: URL: https://github.com/apache/solr/pull/2824#issuecomment-2450823568 Even if today we only use it for testing (because only we know of its secret existence), isn't the same mechanism appropriate for a cluster? It needn't be the *only* way to set it, of cours

Re: [PR] Actually make collections PRS enabled in tests [solr]

2024-10-31 Thread via GitHub
HoustonPutman commented on PR #2824: URL: https://github.com/apache/solr/pull/2824#issuecomment-2450294605 It is not advertised at all, I believe it is just used for testing. But I think default in the name is fine. `Solr.cloud.prs=true`, doesn't really tell me what I'm setting to true. May

Re: [PR] Actually make collections PRS enabled in tests [solr]

2024-10-30 Thread via GitHub
dsmiley commented on PR #2824: URL: https://github.com/apache/solr/pull/2824#issuecomment-2448733108 So the change is to non-test code but it's actually about tests? Would it be more accurate to say that there was a partial/broken attempt to make a cluster-wide default for PRS but this PR