[jira] [Commented] (SOLR-16858) Allow KnnQParser to selectively apply filters

2024-02-09 Thread Alessandro Benedetti (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16858?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17816040#comment-17816040 ] Alessandro Benedetti commented on SOLR-16858: - Thank you for the contribution

[jira] [Commented] (SOLR-16858) Allow KnnQParser to selectively apply filters

2024-02-08 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16858?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17815874#comment-17815874 ] ASF subversion and git services commented on SOLR-16858: Commit d

[jira] [Commented] (SOLR-16858) Allow KnnQParser to selectively apply filters

2024-02-08 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16858?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17815865#comment-17815865 ] ASF subversion and git services commented on SOLR-16858: Commit b

[jira] [Commented] (SOLR-16858) Allow KnnQParser to selectively apply filters

2024-02-08 Thread Elia Porciani (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16858?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17815682#comment-17815682 ] Elia Porciani commented on SOLR-16858: -- I've just gone through the code, and the cha

[jira] [Commented] (SOLR-16858) Allow KnnQParser to selectively apply filters

2024-02-07 Thread Chris M. Hostetter (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16858?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17815355#comment-17815355 ] Chris M. Hostetter commented on SOLR-16858: --- {quote}A minor thing that remains

[jira] [Commented] (SOLR-16858) Allow KnnQParser to selectively apply filters

2024-02-06 Thread Alessandro Benedetti (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16858?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17815029#comment-17815029 ] Alessandro Benedetti commented on SOLR-16858: - [~hossman] thanks for your eff

[jira] [Commented] (SOLR-16858) Allow KnnQParser to selectively apply filters

2024-02-06 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16858?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17815019#comment-17815019 ] ASF subversion and git services commented on SOLR-16858: Commit 2

[jira] [Commented] (SOLR-16858) Allow KnnQParser to selectively apply filters

2024-02-05 Thread Chris M. Hostetter (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16858?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17814552#comment-17814552 ] Chris M. Hostetter commented on SOLR-16858: --- {quote}I have some minor concerns

[jira] [Commented] (SOLR-16858) Allow KnnQParser to selectively apply filters

2024-02-05 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16858?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17814551#comment-17814551 ] ASF subversion and git services commented on SOLR-16858: Commit c

[jira] [Commented] (SOLR-16858) Allow KnnQParser to selectively apply filters

2024-02-05 Thread Alessandro Benedetti (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16858?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17814325#comment-17814325 ] Alessandro Benedetti commented on SOLR-16858: - Thanks [~hossman] for the cont

[jira] [Commented] (SOLR-16858) Allow KnnQParser to selectively apply filters

2024-02-04 Thread Chris M. Hostetter (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16858?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17814138#comment-17814138 ] Chris M. Hostetter commented on SOLR-16858: --- Alessandro: Any feedback or concer

[jira] [Commented] (SOLR-16858) Allow KnnQParser to selectively apply filters

2024-01-30 Thread Chris M. Hostetter (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16858?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17812478#comment-17812478 ] Chris M. Hostetter commented on SOLR-16858: --- {quote} I'm about to go offline un

[jira] [Commented] (SOLR-16858) Allow KnnQParser to selectively apply filters

2024-01-30 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16858?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17812477#comment-17812477 ] ASF subversion and git services commented on SOLR-16858: Commit 6

[jira] [Commented] (SOLR-16858) Allow KnnQParser to selectively apply filters

2024-01-18 Thread Chris M. Hostetter (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16858?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17808408#comment-17808408 ] Chris M. Hostetter commented on SOLR-16858: --- yeah, sorry – i am coming back to

[jira] [Commented] (SOLR-16858) Allow KnnQParser to selectively apply filters

2024-01-18 Thread Alessandro Benedetti (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16858?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17808262#comment-17808262 ] Alessandro Benedetti commented on SOLR-16858: - I spent some peaceful and not

[jira] [Commented] (SOLR-16858) Allow KnnQParser to selectively apply filters

2023-12-20 Thread Chris M. Hostetter (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16858?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17799220#comment-17799220 ] Chris M. Hostetter commented on SOLR-16858: --- (NOTE: I'm responding to some ques

[jira] [Commented] (SOLR-16858) Allow KnnQParser to selectively apply filters

2023-12-19 Thread Alessandro Benedetti (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16858?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17798686#comment-17798686 ] Alessandro Benedetti commented on SOLR-16858: - I did a first review and I hav

[jira] [Commented] (SOLR-16858) Allow KnnQParser to selectively apply filters

2023-12-19 Thread Alessandro Benedetti (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16858?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17798675#comment-17798675 ] Alessandro Benedetti commented on SOLR-16858: - I also agree with David, few p

[jira] [Commented] (SOLR-16858) Allow KnnQParser to selectively apply filters

2023-12-19 Thread Alessandro Benedetti (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16858?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17798674#comment-17798674 ] Alessandro Benedetti commented on SOLR-16858: - I read everything and I agree

[jira] [Commented] (SOLR-16858) Allow KnnQParser to selectively apply filters

2023-12-18 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16858?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17798438#comment-17798438 ] David Smiley commented on SOLR-16858: - IMO PostFilters are so special that they deser

[jira] [Commented] (SOLR-16858) Allow KnnQParser to selectively apply filters

2023-12-18 Thread Chris M. Hostetter (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16858?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17798322#comment-17798322 ] Chris M. Hostetter commented on SOLR-16858: --- Also, FWIW: * We should definitel

[jira] [Commented] (SOLR-16858) Allow KnnQParser to selectively apply filters

2023-12-18 Thread Chris M. Hostetter (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16858?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17798321#comment-17798321 ] Chris M. Hostetter commented on SOLR-16858: --- {quote}...let me explain here and

[jira] [Commented] (SOLR-16858) Allow KnnQParser to selectively apply filters

2023-12-18 Thread Alessandro Benedetti (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16858?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17798171#comment-17798171 ] Alessandro Benedetti commented on SOLR-16858: - Sure [~hossman], let me explai

[jira] [Commented] (SOLR-16858) Allow KnnQParser to selectively apply filters

2023-12-15 Thread Chris M. Hostetter (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16858?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17797323#comment-17797323 ] Chris M. Hostetter commented on SOLR-16858: --- I personally dislike PRs as a deve

[jira] [Commented] (SOLR-16858) Allow KnnQParser to selectively apply filters

2023-12-15 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16858?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17797322#comment-17797322 ] ASF subversion and git services commented on SOLR-16858: Commit 6

[jira] [Commented] (SOLR-16858) Allow KnnQParser to selectively apply filters

2023-12-15 Thread Alessandro Benedetti (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16858?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17797119#comment-17797119 ] Alessandro Benedetti commented on SOLR-16858: - Thanks for the contribution [~