Re: [PR] exclude eclipse settings from validation [solr]

2023-11-22 Thread via GitHub
madrob commented on PR #2082: URL: https://github.com/apache/solr/pull/2082#issuecomment-1823713512 Excellent, thank you! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

Re: [PR] exclude eclipse settings from validation [solr]

2023-11-22 Thread via GitHub
madrob merged PR #2082: URL: https://github.com/apache/solr/pull/2082 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org

Re: [PR] exclude eclipse settings from validation [solr]

2023-11-16 Thread via GitHub
culmat commented on PR #2082: URL: https://github.com/apache/solr/pull/2082#issuecomment-1815385797 Hi @madrob, this replaces #2081. Sorry didn't get my git history and the PR in sync. I have implemented you review https://github.com/apache/solr/pull/2081#pullrequestreview-1732983259

[PR] exclude eclipse settings from validation [solr]

2023-11-16 Thread via GitHub
culmat opened a new pull request, #2082: URL: https://github.com/apache/solr/pull/2082 # Description Gradle build fails because of eclipse internal licenses # Solution exclude eclipse settings from validation # Tests Gradle build runs again. # Checkli