Re: [PR] Use hostContext property for RewriteHandler rules [solr]

2024-04-08 Thread via GitHub
epugh commented on PR #2388: URL: https://github.com/apache/solr/pull/2388#issuecomment-2043326665 @wwelling based on the conversation above, I am going to close this PR. If you decide to move forward with the nesting of both `/solr` and `/api` as a new feature, please open a JIRA, and I'd

Re: [PR] Use hostContext property for RewriteHandler rules [solr]

2024-04-08 Thread via GitHub
epugh closed pull request #2388: Use hostContext property for RewriteHandler rules URL: https://github.com/apache/solr/pull/2388 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

Re: [PR] Use hostContext property for RewriteHandler rules [solr]

2024-04-08 Thread via GitHub
dsmiley commented on PR #2388: URL: https://github.com/apache/solr/pull/2388#issuecomment-2042929556 My concern is avoiding complexity 99+% of users don't need. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL a

Re: [PR] Use hostContext property for RewriteHandler rules [solr]

2024-04-08 Thread via GitHub
dsmiley commented on PR #2388: URL: https://github.com/apache/solr/pull/2388#issuecomment-2042927447 I think aliasing /solr would be simpler than inserting a root. And while I wasn't supportive of aliasing... if it can be done simply in jetty.xml and toggled off then why not. -- This is

Re: [PR] Use hostContext property for RewriteHandler rules [solr]

2024-04-08 Thread via GitHub
epugh commented on PR #2388: URL: https://github.com/apache/solr/pull/2388#issuecomment-2042870864 I chatted a bit with @gerlowskija about this ticket, and I think he was supportive of the idea of being able to insert a root hostcontext that would go between `http://myserver:8983` and the `

Re: [PR] Use hostContext property for RewriteHandler rules [solr]

2024-04-08 Thread via GitHub
wwelling commented on PR #2388: URL: https://github.com/apache/solr/pull/2388#issuecomment-2042852384 @dsmiley thanks. We will give that a try. Would be easy enough to mount a file for additional routing. Will have to see if it supports system variable or environment variable substitution.

Re: [PR] Use hostContext property for RewriteHandler rules [solr]

2024-04-04 Thread via GitHub
dsmiley commented on PR #2388: URL: https://github.com/apache/solr/pull/2388#issuecomment-2038656809 ehhh, no I don't TBH. At least it's somewhat easy to create a new server/etc/jetty-customAdditions.xml and it'll be loaded. -- This is an automated message from the Apache Git Service. T

Re: [PR] Use hostContext property for RewriteHandler rules [solr]

2024-04-04 Thread via GitHub
wwelling commented on PR #2388: URL: https://github.com/apache/solr/pull/2388#issuecomment-2038265317 @dsmiley, thanks. I'll look into additional Jetty routing. Do think it is a reasonable request of the [Solr Docker](https://hub.docker.com/_/solr) image to afford environment driven context

Re: [PR] Use hostContext property for RewriteHandler rules [solr]

2024-04-04 Thread via GitHub
dsmiley commented on PR #2388: URL: https://github.com/apache/solr/pull/2388#issuecomment-2037652388 @wwelling You can configure Solr's Jetty to map `/foo` to `/solr` if that would help. I think the overall objective was to reduce internal code maintenance on an option that didn't se

Re: [PR] Use hostContext property for RewriteHandler rules [solr]

2024-04-04 Thread via GitHub
wwelling commented on PR #2388: URL: https://github.com/apache/solr/pull/2388#issuecomment-2037401821 Hi @epugh, our use case is through a constraint from load balancing requiring matching path with application context path. We have a solution with an additional application sidecar proxy bu

Re: [PR] Use hostContext property for RewriteHandler rules [solr]

2024-04-03 Thread via GitHub
epugh commented on PR #2388: URL: https://github.com/apache/solr/pull/2388#issuecomment-2035531253 IIRC it was actually not well supported in recent versions of Solr, it may even not have worked at all in the 8x line... With the V2 api's starting to live under `/api`, we want to make `/so

Re: [PR] Use hostContext property for RewriteHandler rules [solr]

2024-04-03 Thread via GitHub
wwelling commented on PR #2388: URL: https://github.com/apache/solr/pull/2388#issuecomment-2035026777 @HoustonPutman thanks for the quick reply. I have been reading about that in the Jira and previous issues/PRs. I noticed `hostContext` is still used in [solr-jetty-context.xml](https

Re: [PR] Use hostContext property for RewriteHandler rules [solr]

2024-04-03 Thread via GitHub
HoustonPutman commented on PR #2388: URL: https://github.com/apache/solr/pull/2388#issuecomment-2034928189 I believe we recently removed the ability to specify a new hostContext in `main`. @epugh @gerlowskija -- This is an automated message from the Apache Git Service. To respond to the

[PR] Use hostContext property for RewriteHandler rules [solr]

2024-04-03 Thread via GitHub
wwelling opened a new pull request, #2388: URL: https://github.com/apache/solr/pull/2388 https://issues.apache.org/jira/browse/SOLR-X # Description Please provide a short description of the changes you're making with this pull request. # Solution P