Re: [PR] Support readOnlyRootFilesystem [solr-operator]

2023-11-10 Thread via GitHub
radu-gheorghe commented on PR #648: URL: https://github.com/apache/solr-operator/pull/648#issuecomment-1805326018 Awesome! Thanks for checking and merging! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

Re: [PR] Support readOnlyRootFilesystem [solr-operator]

2023-11-09 Thread via GitHub
HoustonPutman merged PR #648: URL: https://github.com/apache/solr-operator/pull/648 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@s

Re: [PR] Support readOnlyRootFilesystem [solr-operator]

2023-11-09 Thread via GitHub
HoustonPutman commented on PR #648: URL: https://github.com/apache/solr-operator/pull/648#issuecomment-1804342449 I added a changelog entry. Once the tests pass, I'll merge. Thanks for the great work! -- This is an automated message from the Apache Git Service. To respond to the message,

Re: [PR] Support readOnlyRootFilesystem [solr-operator]

2023-11-08 Thread via GitHub
radu-gheorghe commented on PR #648: URL: https://github.com/apache/solr-operator/pull/648#issuecomment-1803264540 Sounds good to me! Does this mean that this PR is good to merge, or should I change something? -- This is an automated message from the Apache Git Service. To respond to the m

Re: [PR] Support readOnlyRootFilesystem [solr-operator]

2023-11-08 Thread via GitHub
HoustonPutman commented on PR #648: URL: https://github.com/apache/solr-operator/pull/648#issuecomment-1802283651 Let's keep it just the zk-init container for now (or all the init containers we do). That way we don't break use cases we don't know about. Not sure there's a giant benefit for

Re: [PR] Support readOnlyRootFilesystem [solr-operator]

2023-11-08 Thread via GitHub
thomaswoeckinger commented on PR #648: URL: https://github.com/apache/solr-operator/pull/648#issuecomment-1801811579 From my point of view, at least some common request for collection creation, modification, deletion and sharding is working, so i think this is good to go -- This is an aut

Re: [PR] Support readOnlyRootFilesystem [solr-operator]

2023-11-07 Thread via GitHub
radu-gheorghe commented on PR #648: URL: https://github.com/apache/solr-operator/pull/648#issuecomment-1798488985 Sounds good, thanks @thomaswoeckinger ! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] Support readOnlyRootFilesystem [solr-operator]

2023-11-07 Thread via GitHub
thomaswoeckinger commented on PR #648: URL: https://github.com/apache/solr-operator/pull/648#issuecomment-1798127176 I think so, i will test it on my side and give you feedback then. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to Gi

Re: [PR] Support readOnlyRootFilesystem [solr-operator]

2023-11-06 Thread via GitHub
radu-gheorghe commented on PR #648: URL: https://github.com/apache/solr-operator/pull/648#issuecomment-1795196347 I just pushed a commit that should fix the breaking tests. I've also experimented with the Solr container using `readOnlyRootFilesystem` by doing `kubectl edit` on the Sta

[PR] Support readOnlyRootFilesystem [solr-operator]

2023-10-26 Thread via GitHub
radu-gheorghe opened a new pull request, #648: URL: https://github.com/apache/solr-operator/pull/648 This should be the first part (or at least an initial attempt at it) for #624 It adds /tmp as emptyDir to the `zk-init` init container. It also sets `readOnlyRootFilesystem` to it. F