epugh commented on PR #2764:
URL: https://github.com/apache/solr/pull/2764#issuecomment-2517033557
> There is another problem I chased down.
Thanks for chasing this. I have some ideas on how to make schema designer
more widely useful for after christmas to try, so I appreciate your mak
dsmiley commented on PR #2764:
URL: https://github.com/apache/solr/pull/2764#issuecomment-2515726655
There is another problem I chased down. So I tried the schema designer
locally from this branch just to see if it was working. It's not, yet not
captured in a test failure (not good). The
iamsanjay commented on code in PR #2764:
URL: https://github.com/apache/solr/pull/2764#discussion_r1867908226
##
solr/modules/sql/src/test/org/apache/solr/handler/sql/TestSQLHandler.java:
##
Review Comment:
Yup failed!
```
./gradlew :solr:modules:sql:test --tests
"or
iamsanjay commented on code in PR #2764:
URL: https://github.com/apache/solr/pull/2764#discussion_r1867903389
##
solr/core/src/java/org/apache/solr/handler/designer/SchemaDesignerConfigSetHelper.java:
##
@@ -125,46 +119,22 @@ class SchemaDesignerConfigSetHelper implements
Schem
iamsanjay commented on code in PR #2764:
URL: https://github.com/apache/solr/pull/2764#discussion_r1867901890
##
solr/modules/sql/src/test/org/apache/solr/handler/sql/TestSQLHandler.java:
##
Review Comment:
Yeah this one I commented because somewhere in the code they
`Inpu
dsmiley commented on code in PR #2764:
URL: https://github.com/apache/solr/pull/2764#discussion_r1862970143
##
solr/core/src/java/org/apache/solr/handler/designer/SchemaDesignerConfigSetHelper.java:
##
@@ -525,40 +495,22 @@ void deleteStoredSampleDocs(String configSet) {
@S
dsmiley commented on code in PR #2764:
URL: https://github.com/apache/solr/pull/2764#discussion_r1802088278
##
solr/core/src/java/org/apache/solr/handler/designer/SchemaDesignerConfigSetHelper.java:
##
@@ -533,11 +516,31 @@ List getStoredSampleDocs(final String
configSet) throw
dsmiley commented on code in PR #2764:
URL: https://github.com/apache/solr/pull/2764#discussion_r1802088278
##
solr/core/src/java/org/apache/solr/handler/designer/SchemaDesignerConfigSetHelper.java:
##
@@ -533,11 +516,31 @@ List getStoredSampleDocs(final String
configSet) throw
iamsanjay opened a new pull request, #2764:
URL: https://github.com/apache/solr/pull/2764
https://issues.apache.org/jira/browse/SOLR-16503
# Checklist
Please review the following and check all that apply:
- [x] I have reviewed the guidelines for [How to
Contribute](https
