Re: [PR] SOLR-17723: Use NamedList.forEach() or iterator() [solr]

2025-04-05 Thread via GitHub
dsmiley merged PR #3295: URL: https://github.com/apache/solr/pull/3295 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.or

Re: [PR] SOLR-17723: Use NamedList.forEach() or iterator() [solr]

2025-04-03 Thread via GitHub
epugh commented on PR #3295: URL: https://github.com/apache/solr/pull/3295#issuecomment-2775105685 I spot checked a couple of places and it all seems to make sense! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the U

Re: [PR] SOLR-17723: Use NamedList.forEach() or iterator() [solr]

2025-04-02 Thread via GitHub
dsmiley commented on PR #3295: URL: https://github.com/apache/solr/pull/3295#issuecomment-2774201096 This was a lot of work... even with ClaudeMind doing many transformations (not all); I did some myself and reviewed it. It even found a (minor?) bug that I left as a TODO for scope reasons.