Re: [PR] SOLR-17705 for V2 API [solr]

2025-04-17 Thread via GitHub
dsmiley merged PR #3282: URL: https://github.com/apache/solr/pull/3282 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.or

Re: [PR] SOLR-17705 for V2 API [solr]

2025-04-17 Thread via GitHub
gerlowskija commented on PR #3282: URL: https://github.com/apache/solr/pull/3282#issuecomment-2812533955 Sorry, was out on some PTO. This all LGTM; merge away! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

Re: [PR] SOLR-17705 for V2 API [solr]

2025-04-14 Thread via GitHub
dsmiley commented on PR #3282: URL: https://github.com/apache/solr/pull/3282#issuecomment-2803635565 Well I'll merge this in another day if I don't hear back. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abo

Re: [PR] SOLR-17705 for V2 API [solr]

2025-04-09 Thread via GitHub
dsmiley commented on PR #3282: URL: https://github.com/apache/solr/pull/3282#issuecomment-2789929157 Good. After merging the parent issue tonight, I'll brush up this PR, adding lucene.experimental but mostly unchanged, update CHANGES.txt. Should be in mergeable shape tomorrow. -- This

Re: [PR] SOLR-17705 for V2 API [solr]

2025-04-09 Thread via GitHub
gerlowskija commented on code in PR #3282: URL: https://github.com/apache/solr/pull/3282#discussion_r2035167694 ## solr/solrj/src/java/org/apache/solr/client/solrj/JacksonDataBindResponseParser.java: ## @@ -0,0 +1,64 @@ +/* + * Licensed to the Apache Software Foundation (ASF) un

Re: [PR] SOLR-17705 for V2 API [solr]

2025-04-09 Thread via GitHub
gerlowskija commented on code in PR #3282: URL: https://github.com/apache/solr/pull/3282#discussion_r2035173216 ## solr/solrj/src/java/org/apache/solr/client/solrj/JacksonDataBindResponseParser.java: ## @@ -0,0 +1,64 @@ +/* + * Licensed to the Apache Software Foundation (ASF) un

Re: [PR] SOLR-17705 for V2 API [solr]

2025-04-09 Thread via GitHub
gerlowskija commented on code in PR #3282: URL: https://github.com/apache/solr/pull/3282#discussion_r2035164196 ## solr/solrj/src/java/org/apache/solr/client/solrj/JacksonDataBindResponseParser.java: ## @@ -0,0 +1,64 @@ +/* + * Licensed to the Apache Software Foundation (ASF) un

Re: [PR] SOLR-17705 for V2 API [solr]

2025-04-03 Thread via GitHub
dsmiley commented on PR #3282: URL: https://github.com/apache/solr/pull/3282#issuecomment-2776630387 > What's the relationship between this PR and the one that underlies it? Are you looking for consensus on both before you merge the underlying one? Yes; these are important changes th

Re: [PR] SOLR-17705 for V2 API [solr]

2025-04-03 Thread via GitHub
dsmiley commented on code in PR #3282: URL: https://github.com/apache/solr/pull/3282#discussion_r2027550274 ## solr/solrj/src/java/org/apache/solr/client/solrj/JacksonDataBindResponseParser.java: ## @@ -0,0 +1,64 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under

Re: [PR] SOLR-17705 for V2 API [solr]

2025-04-03 Thread via GitHub
dsmiley commented on code in PR #3282: URL: https://github.com/apache/solr/pull/3282#discussion_r2027539523 ## solr/solrj/src/java/org/apache/solr/client/solrj/JacksonDataBindResponseParser.java: ## @@ -0,0 +1,64 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under

Re: [PR] SOLR-17705 for V2 API [solr]

2025-04-03 Thread via GitHub
dsmiley commented on code in PR #3282: URL: https://github.com/apache/solr/pull/3282#discussion_r2027510686 ## solr/solrj/src/java/org/apache/solr/client/solrj/JacksonDataBindResponseParser.java: ## @@ -0,0 +1,64 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under

Re: [PR] SOLR-17705 for V2 API [solr]

2025-04-03 Thread via GitHub
dsmiley commented on code in PR #3282: URL: https://github.com/apache/solr/pull/3282#discussion_r2027509100 ## solr/solrj/src/java/org/apache/solr/client/solrj/JacksonDataBindResponseParser.java: ## @@ -0,0 +1,64 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under

Re: [PR] SOLR-17705 for V2 API [solr]

2025-04-03 Thread via GitHub
gerlowskija commented on code in PR #3282: URL: https://github.com/apache/solr/pull/3282#discussion_r2026858878 ## solr/solrj/src/java/org/apache/solr/client/solrj/JacksonDataBindResponseParser.java: ## @@ -0,0 +1,64 @@ +/* + * Licensed to the Apache Software Foundation (ASF) un

Re: [PR] SOLR-17705 for V2 API [solr]

2025-03-27 Thread via GitHub
dsmiley commented on PR #3282: URL: https://github.com/apache/solr/pull/3282#issuecomment-2760232448 WDYT @gerlowskija ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[PR] SOLR-17705 for V2 API [solr]

2025-03-22 Thread via GitHub
dsmiley opened a new pull request, #3282: URL: https://github.com/apache/solr/pull/3282 https://issues.apache.org/jira/browse/SOLR-17705 Moves JSON parsing into the ResponseParser where it belongs. Removes generated intermediate SolrResponse layer classes. This PR is branched

Re: [PR] SOLR-17705 for V2 API [solr]

2025-03-22 Thread via GitHub
dsmiley commented on code in PR #3282: URL: https://github.com/apache/solr/pull/3282#discussion_r2008841563 ## solr/core/src/java/org/apache/solr/packagemanager/PackageUtils.java: ## @@ -96,7 +97,7 @@ public static void postFile(SolrClient client, ByteBuffer buffer, String name