iamsanjay merged PR #3208:
URL: https://github.com/apache/solr/pull/3208
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.
dsmiley commented on PR #3208:
URL: https://github.com/apache/solr/pull/3208#issuecomment-2688573136
tests pass!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscr
dsmiley commented on code in PR #3208:
URL: https://github.com/apache/solr/pull/3208#discussion_r1973633118
##
solr/core/src/test/org/apache/solr/security/BasicAuthIntegrationTest.java:
##
@@ -373,6 +376,32 @@ public void testBasicAuth() throws Exception {
assertAuthMetri
iamsanjay commented on PR #3208:
URL: https://github.com/apache/solr/pull/3208#issuecomment-2687064213
If I look the default connection and socket timeouts.
```
HttpClientUtil.DEFAULT_SO_TIMEOUT = 60,000
HttpClientUtil.DEFAULT_CONNECT_TIMEOUT = 60,000
```
But I will make th
iamsanjay commented on PR #3208:
URL: https://github.com/apache/solr/pull/3208#issuecomment-2687044559
We are creating client inside ZkController with custom timeouts
```
http2SolrClient =
new Http2SolrClient.Builder()
.withHttpClient(cc.getDefaultHttpSolr
dsmiley commented on PR #3208:
URL: https://github.com/apache/solr/pull/3208#issuecomment-2684074527
I would _prefer_ we initialize the httpClients with security as soon as
possible, before they are obtained, even if the design seems to support dynamic
changes after creation. It'd be bette
iamsanjay commented on PR #3208:
URL: https://github.com/apache/solr/pull/3208#issuecomment-2677628347
https://github.com/user-attachments/assets/2c5da665-2087-464d-b7b4-ae95ede9ce56";
/>
It's not about the lazy loading. `SolrClientProvider` object is being used
inside the `ZkControl
iamsanjay commented on PR #3208:
URL: https://github.com/apache/solr/pull/3208#issuecomment-2677547561
Test case!
```
@Test
public void testAuth() throws Exception {
// This succeeds with auth enabled
CollectionAdminRequest.createCollection("c123", "conf", 1, 1)
iamsanjay commented on PR #3208:
URL: https://github.com/apache/solr/pull/3208#issuecomment-2677546452
This is not the final solution. I created this to initiate discussion on the
best possible approach to solving this.
--
This is an automated message from the Apache Git Service.
To respo
iamsanjay opened a new pull request, #3208:
URL: https://github.com/apache/solr/pull/3208
https://issues.apache.org/jira/browse/SOLR-17644
# Checklist
Please review the following and check all that apply:
- [x] I have reviewed the guidelines for [How to
Contribute](https
10 matches
Mail list logo
