bruno-roustant merged PR #2892:
URL: https://github.com/apache/solr/pull/2892
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.ap
dsmiley commented on code in PR #2892:
URL: https://github.com/apache/solr/pull/2892#discussion_r1867487293
##
solr/CHANGES.txt:
##
@@ -229,6 +229,8 @@ Bug Fixes
* SOLR-17575: Fixed broken backwards compatibility with the legacy
"langid.whitelist" config in Solr Langid. (Jan
dsmiley commented on code in PR #2892:
URL: https://github.com/apache/solr/pull/2892#discussion_r1867330538
##
solr/solrj/src/java/org/apache/solr/common/cloud/ClusterState.java:
##
@@ -387,7 +386,7 @@ public boolean equals(Object obj) {
/** Internal API used only by ZkStat
bruno-roustant commented on PR #2892:
URL: https://github.com/apache/solr/pull/2892#issuecomment-2513761279
This is already changed. ClusterState.setLiveNodes sets the immutable copy
and getLiveNodes gets its reference.
--
This is an automated message from the Apache Git Service.
To respo
dsmiley commented on code in PR #2892:
URL: https://github.com/apache/solr/pull/2892#discussion_r1865912289
##
solr/core/src/test/org/apache/solr/security/AllowListUrlCheckerTest.java:
##
@@ -196,6 +200,46 @@ public void testHostParsingNoProtocol() throws Exception {
e
bruno-roustant opened a new pull request, #2892:
URL: https://github.com/apache/solr/pull/2892
Remove the host allow list cache from ClusterState and move it to it's only
caller AllowListUrlChecker. There it is cached based on live nodes.
--
This is an automated message from the Apache Gi
