Re: [PR] SOLR-17537: Manage ZK Compression through Curator [solr]

2025-03-11 Thread via GitHub
HoustonPutman merged PR #2849: URL: https://github.com/apache/solr/pull/2849 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apa

Re: [PR] SOLR-17537: Manage ZK Compression through Curator [solr]

2025-03-07 Thread via GitHub
HoustonPutman commented on PR #2849: URL: https://github.com/apache/solr/pull/2849#issuecomment-2707394159 Yeah, I'm not changing how the configuration is done, just how it's handled in the backend. -- This is an automated message from the Apache Git Service. To respond to the message, pl

Re: [PR] SOLR-17537: Manage ZK Compression through Curator [solr]

2025-03-07 Thread via GitHub
HoustonPutman commented on PR #2849: URL: https://github.com/apache/solr/pull/2849#issuecomment-2707275445 With the Curator Global Compression stuff merged, we should be good to go here. -- This is an automated message from the Apache Git Service. To respond to the message, please log on

Re: [PR] SOLR-17537: Manage ZK Compression through Curator [solr]

2024-11-07 Thread via GitHub
dsmiley commented on PR #2849: URL: https://github.com/apache/solr/pull/2849#issuecomment-2462384200 > are you suggesting that it just be a default? And so any data, on it's way in is compressed, and on it's way back out is uncompressed? Interesting idea! No, but it's confusing becaus

Re: [PR] SOLR-17537: Manage ZK Compression through Curator [solr]

2024-11-07 Thread via GitHub
HoustonPutman commented on PR #2849: URL: https://github.com/apache/solr/pull/2849#issuecomment-2462698457 The idea is that with this we can eventually use the Curator recipes, which will require that our interactions with the CuratorFramework and SolrZkClient behave similarly. So yes, we c

Re: [PR] SOLR-17537: Manage ZK Compression through Curator [solr]

2024-11-07 Thread via GitHub
epugh commented on PR #2849: URL: https://github.com/apache/solr/pull/2849#issuecomment-2461874627 > Could we call compress() universally and then our compressor chooses to only compress based on our criteria (state.json)? Just an idea off the top of my head; I don't know where compress() i

Re: [PR] SOLR-17537: Manage ZK Compression through Curator [solr]

2024-11-06 Thread via GitHub
dsmiley commented on PR #2849: URL: https://github.com/apache/solr/pull/2849#issuecomment-2461467862 Could we call compress() universally and then our compressor chooses to only compress based on our criteria (state.json)? Just an idea off the top of my head; I don't know where compress()

[PR] SOLR-17537: Manage ZK Compression through Curator [solr]

2024-11-06 Thread via GitHub
HoustonPutman opened a new pull request, #2849: URL: https://github.com/apache/solr/pull/2849 https://issues.apache.org/jira/browse/SOLR-17537 Unfortunately, Curator currently requires that users explicitly use (`.compress()`) in order to enable compression for a zNode. We need to add