Re: [PR] SOLR-17495: Change CLI delete command to not delete configs by default. [solr]

2024-11-08 Thread via GitHub
epugh merged PR #2761: URL: https://github.com/apache/solr/pull/2761 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org

Re: [PR] SOLR-17495: Change CLI delete command to not delete configs by default. [solr]

2024-11-07 Thread via GitHub
epugh commented on PR #2761: URL: https://github.com/apache/solr/pull/2761#issuecomment-2461934671 @janhoy would you mind weighing in ont this PR since it changes a default behavior? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

Re: [PR] SOLR-17495: Change CLI delete command to not delete configs by default. [solr]

2024-10-14 Thread via GitHub
epugh commented on PR #2761: URL: https://github.com/apache/solr/pull/2761#issuecomment-2411861328 Leaving "tutorial-films.adoc" alone, as it uses `_default` and we wouldn't want to delete it. -- This is an automated message from the Apache Git Service. To respond to the message, please l

Re: [PR] SOLR-17495: Change CLI delete command to not delete configs by default. [solr]

2024-10-14 Thread via GitHub
epugh commented on code in PR #2761: URL: https://github.com/apache/solr/pull/2761#discussion_r1799860269 ## solr/core/src/java/org/apache/solr/cli/DeleteTool.java: ## @@ -198,13 +187,13 @@ protected void deleteCollection(CloudSolrClient cloudSolrClient, CommandLine cli

Re: [PR] SOLR-17495: Change CLI delete command to not delete configs by default. [solr]

2024-10-14 Thread via GitHub
malliaridis commented on code in PR #2761: URL: https://github.com/apache/solr/pull/2761#discussion_r1799701043 ## solr/core/src/java/org/apache/solr/cli/DeleteTool.java: ## @@ -198,13 +187,13 @@ protected void deleteCollection(CloudSolrClient cloudSolrClient, CommandLine cli

Re: [PR] SOLR-17495: Change CLI delete command to not delete configs by default. [solr]

2024-10-12 Thread via GitHub
epugh commented on PR #2761: URL: https://github.com/apache/solr/pull/2761#issuecomment-2408625057 @malliaridis -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscr

[PR] SOLR-17495: Change CLI delete command to not delete configs by default. [solr]

2024-10-12 Thread via GitHub
epugh opened a new pull request, #2761: URL: https://github.com/apache/solr/pull/2761 https://issues.apache.org/jira/browse/SOLR-17495 # Description See jira # Solution Makes --delete-config a opt in flag that specifies the user wants to delete their config al