dsmiley merged PR #2737:
URL: https://github.com/apache/solr/pull/2737
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.or
psalagnac commented on code in PR #2737:
URL: https://github.com/apache/solr/pull/2737#discussion_r1829398709
##
solr/test-framework/src/java/org/apache/solr/cloud/AbstractDistribZkTestBase.java:
##
@@ -242,45 +240,15 @@ public static void waitForCollectionToDisappear(
log.
dsmiley commented on PR #2737:
URL: https://github.com/apache/solr/pull/2737#issuecomment-2455879410
Probably just a one-liner left and I'll merge away :-)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
dsmiley commented on code in PR #2737:
URL: https://github.com/apache/solr/pull/2737#discussion_r1828513954
##
solr/test-framework/src/java/org/apache/solr/cloud/AbstractDistribZkTestBase.java:
##
@@ -242,45 +240,15 @@ public static void waitForCollectionToDisappear(
log.in
psalagnac commented on PR #2737:
URL: https://github.com/apache/solr/pull/2737#issuecomment-2454956000
> One thought, is there a way to enforce the use of waitForState() pattern
via any of our code quality tools?
Not sure how we can automate decision on whether usages of `Timeout` are
psalagnac commented on code in PR #2737:
URL: https://github.com/apache/solr/pull/2737#discussion_r1827860425
##
solr/core/src/test/org/apache/solr/cloud/TestRebalanceLeaders.java:
##
@@ -604,74 +572,61 @@ private void forceUpdateCollectionStatus() {
// Since we have to res
psalagnac commented on code in PR #2737:
URL: https://github.com/apache/solr/pull/2737#discussion_r1827855744
##
solr/test-framework/src/java/org/apache/solr/cloud/AbstractDistribZkTestBase.java:
##
@@ -242,45 +240,15 @@ public static void waitForCollectionToDisappear(
log.
psalagnac commented on code in PR #2737:
URL: https://github.com/apache/solr/pull/2737#discussion_r1827843673
##
solr/core/src/java/org/apache/solr/cloud/api/collections/CreateCollectionCmd.java:
##
@@ -221,24 +223,19 @@ public void call(ClusterState clusterState, ZkNodeProps
m
epugh commented on code in PR #2737:
URL: https://github.com/apache/solr/pull/2737#discussion_r1812438320
##
solr/core/src/test/org/apache/solr/cloud/TestRebalanceLeaders.java:
##
@@ -604,74 +572,61 @@ private void forceUpdateCollectionStatus() {
// Since we have to restart
dsmiley commented on code in PR #2737:
URL: https://github.com/apache/solr/pull/2737#discussion_r1811699448
##
solr/core/src/test/org/apache/solr/cloud/TestRebalanceLeaders.java:
##
@@ -604,74 +572,61 @@ private void forceUpdateCollectionStatus() {
// Since we have to resta
dsmiley commented on PR #2737:
URL: https://github.com/apache/solr/pull/2737#issuecomment-2411992713
A line of javadocs on TimeOut recommending waitForState would be good but
perhaps arguably a distraction to a general utility -- :shrug: whatever. I
don't think we'll backslide much if all/
epugh commented on code in PR #2737:
URL: https://github.com/apache/solr/pull/2737#discussion_r1799884914
##
solr/core/src/test/org/apache/solr/cloud/TestRebalanceLeaders.java:
##
@@ -604,74 +572,61 @@ private void forceUpdateCollectionStatus() {
// Since we have to restart
dsmiley commented on code in PR #2737:
URL: https://github.com/apache/solr/pull/2737#discussion_r1798764375
##
solr/core/src/test/org/apache/solr/cloud/TestRebalanceLeaders.java:
##
@@ -604,74 +572,61 @@ private void forceUpdateCollectionStatus() {
// Since we have to resta
13 matches
Mail list logo
