github-actions[bot] commented on PR #2687:
URL: https://github.com/apache/solr/pull/2687#issuecomment-2480856141
This PR has had no activity for 60 days and is now labeled as stale. Any
new activity will remove the stale label. To attract more reviewers, please
tag people who might be fam
janhoy commented on PR #2687:
URL: https://github.com/apache/solr/pull/2687#issuecomment-2354999765
I just saw SOLR-17455 coming in. While mentioning OpenTracing is correct for
9.x, for 10.0 it is gone, so perhaps when you add refGuide docs for this PR,
you can also `s/OpenTracing/OpenTelem
dsmiley commented on PR #2687:
URL: https://github.com/apache/solr/pull/2687#issuecomment-2351373380
I'm a little unhappy with keeping TracerConfigurator named this while having
it return an OpenTelemetry. Really; we're embracing OpenTelemetry here. I
would love to use OpenTelemetry for m
dsmiley commented on PR #2687:
URL: https://github.com/apache/solr/pull/2687#issuecomment-2351370178
When I run the agent, I provide an Otel properties file with: (an excerpt)
```
otel.metrics.exporter=none
otel.logs.exporter=none
otel.instrumentation.common.default-enabled=false
dsmiley commented on code in PR #2687:
URL: https://github.com/apache/solr/pull/2687#discussion_r1741041201
##
solr/core/src/java/org/apache/solr/core/TracerConfigurator.java:
##
@@ -38,33 +41,53 @@
public abstract class TracerConfigurator implements NamedListInitializedPlugin
dsmiley commented on code in PR #2687:
URL: https://github.com/apache/solr/pull/2687#discussion_r1740338583
##
solr/core/src/java/org/apache/solr/core/TracerConfigurator.java:
##
@@ -38,33 +41,53 @@
public abstract class TracerConfigurator implements NamedListInitializedPlugin
dsmiley opened a new pull request, #2687:
URL: https://github.com/apache/solr/pull/2687
https://issues.apache.org/jira/browse/SOLR-17432
Admittedly there's a lot going on here; the PR is more of a refactoring /
minor improvements that also happens to support the Otel agent too, as it'
