Re: [PR] SOLR-17394: Check response status in IndexFetcher [solr]

2024-08-16 Thread via GitHub
epugh commented on code in PR #2621: URL: https://github.com/apache/solr/pull/2621#discussion_r1719667781 ## solr/core/src/java/org/apache/solr/handler/IndexFetcher.java: ## @@ -1988,16 +1989,38 @@ private FastInputStream getStream() throws IOException { req.setBasePath

Re: [PR] SOLR-17394: Check response status in IndexFetcher [solr]

2024-08-15 Thread via GitHub
dsmiley commented on PR #2621: URL: https://github.com/apache/solr/pull/2621#issuecomment-2292801661 I see less than 2 days: August 6th 3:52pm -> 8th 8:32am. That's too short. Also we generally give advanced merge notice if there was no feedback whatsoever. -- This is an automated mess

Re: [PR] SOLR-17394: Check response status in IndexFetcher [solr]

2024-08-15 Thread via GitHub
gerlowskija commented on PR #2621: URL: https://github.com/apache/solr/pull/2621#issuecomment-2292530594 > This was merged so fast that it got not review; I wanted to review it I thought 3 days was a reasonable length of time to wait on a pretty clear and minor bugfix; I hope i'm not

Re: [PR] SOLR-17394: Check response status in IndexFetcher [solr]

2024-08-15 Thread via GitHub
gerlowskija commented on code in PR #2621: URL: https://github.com/apache/solr/pull/2621#discussion_r1719161093 ## solr/core/src/java/org/apache/solr/handler/IndexFetcher.java: ## @@ -1988,16 +1989,38 @@ private FastInputStream getStream() throws IOException { req.setBa

Re: [PR] SOLR-17394: Check response status in IndexFetcher [solr]

2024-08-15 Thread via GitHub
gerlowskija commented on code in PR #2621: URL: https://github.com/apache/solr/pull/2621#discussion_r1719161279 ## solr/core/src/java/org/apache/solr/handler/IndexFetcher.java: ## @@ -1988,16 +1989,38 @@ private FastInputStream getStream() throws IOException { req.setBa

Re: [PR] SOLR-17394: Check response status in IndexFetcher [solr]

2024-08-08 Thread via GitHub
dsmiley commented on code in PR #2621: URL: https://github.com/apache/solr/pull/2621#discussion_r1709937216 ## solr/core/src/java/org/apache/solr/handler/IndexFetcher.java: ## @@ -1988,16 +1989,38 @@ private FastInputStream getStream() throws IOException { req.setBasePa

Re: [PR] SOLR-17394: Check response status in IndexFetcher [solr]

2024-08-08 Thread via GitHub
gerlowskija merged PR #2621: URL: https://github.com/apache/solr/pull/2621 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apach

[PR] SOLR-17394: Check response status in IndexFetcher [solr]

2024-08-06 Thread via GitHub
gerlowskija opened a new pull request, #2621: URL: https://github.com/apache/solr/pull/2621 https://issues.apache.org/jira/browse/SOLR-17394 # Description Prior to this commit, IndexFetcher would mis-read 404 responses from other nodes. It eventually catches this mistake and r