epugh merged PR #2820:
URL: https://github.com/apache/solr/pull/2820
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
epugh commented on PR #2820:
URL: https://github.com/apache/solr/pull/2820#issuecomment-2452141047
> Looks good to me, there were a lot of changes and we definitely have a few
more places we can reduce a few more lines. But that's for another PR.
>
> @epugh It seems that the changes f
epugh commented on PR #2820:
URL: https://github.com/apache/solr/pull/2820#issuecomment-2451761906
I'd love to get this merged today if anyone can give it a quick pass. I am
sure there is more we can do, but would like to unblock some other PR's.
--
This is an automated message from the
epugh commented on code in PR #2820:
URL: https://github.com/apache/solr/pull/2820#discussion_r1824808865
##
solr/core/src/java/org/apache/solr/cli/SolrCLI.java:
##
@@ -215,18 +150,16 @@ public static void exit(int exitStatus) {
public static void main(String[] args) throws E
malliaridis commented on code in PR #2820:
URL: https://github.com/apache/solr/pull/2820#discussion_r1824945975
##
solr/core/src/java/org/apache/solr/cli/SolrCLI.java:
##
@@ -215,18 +150,16 @@ public static void exit(int exitStatus) {
public static void main(String[] args) th
epugh commented on code in PR #2820:
URL: https://github.com/apache/solr/pull/2820#discussion_r1824234733
##
solr/core/src/java/org/apache/solr/cli/ApiTool.java:
##
@@ -57,37 +56,19 @@ public List getOptions() {
.longOpt("solr-url")
.argName("URL")
epugh commented on PR #2820:
URL: https://github.com/apache/solr/pull/2820#issuecomment-2450346488
I also anticipate that post this merge and some of the other inflight PR's,
that we will want to reach out and ask the community for another round of
testing on LInux and windows ;-)
--
Thi
epugh commented on PR #2820:
URL: https://github.com/apache/solr/pull/2820#issuecomment-2450344779
I **think** I am done and ready for more review. I clearly was NOT done
when I thought I was the first time!!!
I love that while we added 176 lines we remove 1092
--
This is
epugh commented on code in PR #2820:
URL: https://github.com/apache/solr/pull/2820#discussion_r1824809265
##
solr/core/src/java/org/apache/solr/cli/SolrCLI.java:
##
@@ -215,18 +150,16 @@ public static void exit(int exitStatus) {
public static void main(String[] args) throws E
epugh commented on PR #2820:
URL: https://github.com/apache/solr/pull/2820#issuecomment-2450147305
> @janhoy in commit
[2f3c0ef](https://github.com/apache/solr/commit/2f3c0ef959b6a1f921217ef30da5347ec17a5b5f)
I removed the passing of the `-j` (Jetty options) into the RunExampleTool
because
epugh commented on PR #2820:
URL: https://github.com/apache/solr/pull/2820#issuecomment-2450138855
@janhoy in commit 2f3c0ef959b6a1f921217ef30da5347ec17a5b5f I removed the
passing of the `-j` (Jetty options) into the RunExampleTool because it was an
option that was ignored. You added the
epugh commented on PR #2820:
URL: https://github.com/apache/solr/pull/2820#issuecomment-2449846136
I am leaving `SolrCLI#getOptionWithDeprecatedAndDefault` but adding some
docs about what it's for, since I suspect we will have another deprecation soon!
--
This is an automated message from
janhoy commented on code in PR #2820:
URL: https://github.com/apache/solr/pull/2820#discussion_r1824575199
##
solr/core/src/java/org/apache/solr/cli/SolrCLI.java:
##
@@ -215,18 +150,16 @@ public static void exit(int exitStatus) {
public static void main(String[] args) throws
epugh commented on code in PR #2820:
URL: https://github.com/apache/solr/pull/2820#discussion_r1824243229
##
solr/packaging/test/test_snapshots.bats:
##
@@ -59,15 +59,15 @@ teardown() {
@test "snapshot list" {
solr snapshot-create -c films --snapshot-name snapshot3 --solr-
epugh commented on PR #2820:
URL: https://github.com/apache/solr/pull/2820#issuecomment-2449861488
for "AuthTool uses flags with Boolean arguments, should be deprecated and
changed before 10" we should make another ticket.
--
This is an automated message from the Apache Git Service.
To re
epugh commented on PR #2820:
URL: https://github.com/apache/solr/pull/2820#issuecomment-2449839719
I hope in the future `solr.cmd` doesn't have helper methods like
`parse_config_args`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
epugh commented on code in PR #2820:
URL: https://github.com/apache/solr/pull/2820#discussion_r1824235207
##
solr/core/src/java/org/apache/solr/cli/ApiTool.java:
##
@@ -57,37 +56,19 @@ public List getOptions() {
.longOpt("solr-url")
.argName("URL")
epugh commented on code in PR #2820:
URL: https://github.com/apache/solr/pull/2820#discussion_r1824242674
##
solr/packaging/test/test_snapshots.bats:
##
@@ -59,15 +59,15 @@ teardown() {
@test "snapshot list" {
solr snapshot-create -c films --snapshot-name snapshot3 --solr-
epugh commented on code in PR #2820:
URL: https://github.com/apache/solr/pull/2820#discussion_r1824240009
##
solr/packaging/test/test_snapshots.bats:
##
@@ -59,15 +59,15 @@ teardown() {
@test "snapshot list" {
solr snapshot-create -c films --snapshot-name snapshot3 --solr-
epugh commented on code in PR #2820:
URL: https://github.com/apache/solr/pull/2820#discussion_r1824239234
##
solr/core/src/java/org/apache/solr/cli/SolrCLI.java:
##
@@ -215,18 +150,16 @@ public static void exit(int exitStatus) {
public static void main(String[] args) throws E
epugh commented on code in PR #2820:
URL: https://github.com/apache/solr/pull/2820#discussion_r1824218403
##
solr/core/src/java/org/apache/solr/cli/ApiTool.java:
##
@@ -57,37 +56,19 @@ public List getOptions() {
.longOpt("solr-url")
.argName("URL")
malliaridis commented on code in PR #2820:
URL: https://github.com/apache/solr/pull/2820#discussion_r1823372644
##
solr/core/src/java/org/apache/solr/cli/ApiTool.java:
##
@@ -57,37 +56,19 @@ public List getOptions() {
.longOpt("solr-url")
.argName("URL"
epugh opened a new pull request, #2820:
URL: https://github.com/apache/solr/pull/2820
https://issues.apache.org/jira/browse/SOLR-17352
# Description
Time to remove options deprecated in 9x.
# Solution
Removing code! Trying to do it one by one by area.
# Tes
23 matches
Mail list logo
