gerlowskija commented on PR #3047:
URL: https://github.com/apache/solr/pull/3047#issuecomment-2637426498
Alright - I think I've addressed the feedback so far? If I've missed
anything, let me know. I've brought it up to date with 'main' and will aim to
merge in the next few days pending an
gerlowskija commented on code in PR #3047:
URL: https://github.com/apache/solr/pull/3047#discussion_r1943253094
##
solr/core/src/java/org/apache/solr/filestore/NodeFileStore.java:
##
@@ -76,135 +66,54 @@ public SolrJerseyResponse getFile(String path, Boolean
sync, String getFro
gerlowskija commented on code in PR #3047:
URL: https://github.com/apache/solr/pull/3047#discussion_r1941803992
##
solr/core/src/java/org/apache/solr/filestore/NodeFileStore.java:
##
@@ -76,135 +66,54 @@ public SolrJerseyResponse getFile(String path, Boolean
sync, String getFro
gerlowskija commented on code in PR #3047:
URL: https://github.com/apache/solr/pull/3047#discussion_r1940306565
##
solr/solr-ref-guide/modules/configuration-guide/pages/package-manager-internals.adoc:
##
@@ -115,7 +115,7 @@ openssl dgst -sha1 -sign my_key.pem runtimelibs.jar |
gerlowskija commented on code in PR #3047:
URL: https://github.com/apache/solr/pull/3047#discussion_r1940305756
##
solr/core/src/java/org/apache/solr/packagemanager/PackageManager.java:
##
@@ -173,7 +173,7 @@ public void uninstall(String packageName, String version)
Str
gerlowskija commented on code in PR #3047:
URL: https://github.com/apache/solr/pull/3047#discussion_r1940305043
##
solr/core/src/java/org/apache/solr/filestore/NodeFileStore.java:
##
@@ -76,135 +66,54 @@ public SolrJerseyResponse getFile(String path, Boolean
sync, String getFro
epugh commented on PR #3047:
URL: https://github.com/apache/solr/pull/3047#issuecomment-2614614636
I enjoyed catching up on the comments on this PR!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go t
gerlowskija commented on code in PR #3047:
URL: https://github.com/apache/solr/pull/3047#discussion_r1929150292
##
solr/api/src/java/org/apache/solr/client/api/endpoint/ClusterFileStoreApis.java:
##
@@ -70,4 +97,23 @@ SolrJerseyResponse deleteFile(
"Indicates
dsmiley commented on code in PR #3047:
URL: https://github.com/apache/solr/pull/3047#discussion_r1924452036
##
solr/core/src/java/org/apache/solr/filestore/DistribFileStore.java:
##
@@ -189,26 +187,32 @@ private boolean fetchFileFromNodeAndPersist(String
fromNode) {
var
epugh commented on code in PR #3047:
URL: https://github.com/apache/solr/pull/3047#discussion_r1924229223
##
solr/api/src/java/org/apache/solr/client/api/endpoint/ClusterFileStoreApis.java:
##
@@ -70,4 +97,23 @@ SolrJerseyResponse deleteFile(
"Indicates whethe
gerlowskija commented on PR #3047:
URL: https://github.com/apache/solr/pull/3047#issuecomment-2603252367
That PR uses the Java interface, and not the HTTP APIs directly, so it
should be fine afaict.
--
This is an automated message from the Apache Git Service.
To respond to the message, pl
epugh commented on PR #3047:
URL: https://github.com/apache/solr/pull/3047#issuecomment-2602733589
Does this impact #3031 ? Since I am using `cc.getFileStore` I don't think
so, but wanted to check.
--
This is an automated message from the Apache Git Service.
To respond to the message,
12 matches
Mail list logo
