Re: [PR] SOLR-17337: Show proper distributed stage id [solr]

2024-07-29 Thread via GitHub
cpoerschke commented on PR #2526: URL: https://github.com/apache/solr/pull/2526#issuecomment-2255532204 closing in favour of #2594 variant -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the spec

Re: [PR] SOLR-17337: Show proper distributed stage id [solr]

2024-07-29 Thread via GitHub
cpoerschke closed pull request #2526: SOLR-17337: Show proper distributed stage id URL: https://github.com/apache/solr/pull/2526 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

Re: [PR] SOLR-17337: Show proper distributed stage id [solr]

2024-07-29 Thread via GitHub
cpoerschke merged PR #2594: URL: https://github.com/apache/solr/pull/2594 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache

Re: [PR] SOLR-17337: Show proper distributed stage id [solr]

2024-07-25 Thread via GitHub
cpoerschke commented on code in PR #2526: URL: https://github.com/apache/solr/pull/2526#discussion_r1691092491 ## solr/core/src/java/org/apache/solr/handler/component/DebugComponent.java: ## @@ -181,16 +183,28 @@ public void modifyRequest(ResponseBuilder rb, SearchComponent who

Re: [PR] SOLR-17337: Show proper distributed stage id [solr]

2024-07-23 Thread via GitHub
cpoerschke commented on code in PR #2526: URL: https://github.com/apache/solr/pull/2526#discussion_r1688403069 ## solr/core/src/test/org/apache/solr/handler/component/DebugComponentTest.java: ## @@ -297,4 +297,12 @@ private void addRequestId(ResponseBuilder rb, String requestId

Re: [PR] SOLR-17337: Show proper distributed stage id [solr]

2024-07-23 Thread via GitHub
cpoerschke commented on code in PR #2526: URL: https://github.com/apache/solr/pull/2526#discussion_r1688403069 ## solr/core/src/test/org/apache/solr/handler/component/DebugComponentTest.java: ## @@ -297,4 +297,12 @@ private void addRequestId(ResponseBuilder rb, String requestId

Re: [PR] SOLR-17337: Show proper distributed stage id [solr]

2024-06-24 Thread via GitHub
cpoerschke commented on PR #2526: URL: https://github.com/apache/solr/pull/2526#issuecomment-2186391578 > I added a simple resolution test. Testing the distributed behaviour would mean adding a new test Solr configuration ... The config APIs could be used instead of having another tes

Re: [PR] SOLR-17337: Show proper distributed stage id [solr]

2024-06-24 Thread via GitHub
cpoerschke commented on code in PR #2526: URL: https://github.com/apache/solr/pull/2526#discussion_r1650892906 ## solr/core/src/java/org/apache/solr/handler/component/DebugComponent.java: ## @@ -181,16 +183,28 @@ public void modifyRequest(ResponseBuilder rb, SearchComponent who

Re: [PR] SOLR-17337: Show proper distributed stage id [solr]

2024-06-23 Thread via GitHub
epugh commented on PR #2526: URL: https://github.com/apache/solr/pull/2526#issuecomment-2184960071 I assigned it to me so I don't loose track of it! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go t

Re: [PR] SOLR-17337: Show proper distributed stage id [solr]

2024-06-23 Thread via GitHub
tboeghk commented on PR #2526: URL: https://github.com/apache/solr/pull/2526#issuecomment-2184950034 I added a simple resolution test. Testing the distributed behaviour would mean adding a new test Solr configuration and adding a new test component that actually does a couple of distributed