Re: [PR] SOLR-17306: fix replication problem on follower restart [solr]

2024-12-19 Thread via GitHub
epugh merged PR #2918: URL: https://github.com/apache/solr/pull/2918 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org

Re: [PR] SOLR-17306: fix replication problem on follower restart [solr]

2024-12-19 Thread via GitHub
epugh commented on PR #2918: URL: https://github.com/apache/solr/pull/2918#issuecomment-2554513658 waiting for checks to complete and then will merge! let's hope my nemesis `CHANGES.txt` doesn't get me! -- This is an automated message from the Apache Git Service. To respond to the me

Re: [PR] SOLR-17306: fix replication problem on follower restart [solr]

2024-12-18 Thread via GitHub
ds-manzinger commented on PR #2918: URL: https://github.com/apache/solr/pull/2918#issuecomment-2552157377 @epugh Sorry for that new Pull Request. Sync with apache/solr broke my history -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[PR] SOLR-17306: fix replication problem on follower restart [solr]

2024-12-18 Thread via GitHub
ds-manzinger opened a new pull request, #2918: URL: https://github.com/apache/solr/pull/2918 https://issues.apache.org/jira/browse/SOLR-X # Description Please provide a short description of the changes you're making with this pull request. # Solution

Re: [PR] SOLR-17306: fix replication problem on follower restart [solr]

2024-12-18 Thread via GitHub
ds-manzinger closed pull request #2874: SOLR-17306: fix replication problem on follower restart URL: https://github.com/apache/solr/pull/2874 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the spec

Re: [PR] SOLR-17306: fix replication problem on follower restart [solr]

2024-12-18 Thread via GitHub
epugh commented on PR #2874: URL: https://github.com/apache/solr/pull/2874#issuecomment-2551837349 @ds-manzinger I just went to merge, and of course my old enemy, `CHANGES.txt` has merge conflict. Would you mine fixing that and then I'll click the merge button! Lookign forward to getting

Re: [PR] SOLR-17306: fix replication problem on follower restart [solr]

2024-12-17 Thread via GitHub
epugh commented on PR #2874: URL: https://github.com/apache/solr/pull/2874#issuecomment-2548198818 I tried to push latest `main` updates to the branch, but i don't have permissions to push to your branch... Could you update and add a CHANGES.txt entry? Using the "via Eric Pugh" style and

Re: [PR] SOLR-17306: fix replication problem on follower restart [solr]

2024-12-16 Thread via GitHub
ds-manzinger commented on PR #2874: URL: https://github.com/apache/solr/pull/2874#issuecomment-2547633448 Is there anybody reviewing that PR? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the s

Re: [PR] SOLR-17306: fix replication problem on follower restart [solr]

2024-11-21 Thread via GitHub
epugh commented on PR #2873: URL: https://github.com/apache/solr/pull/2873#issuecomment-2490590424 Closing in favour of the main branch. Will dig into probably early next week unless someone beats me too it! -- This is an automated message from the Apache Git Service. To respond to the

Re: [PR] SOLR-17306: fix replication problem on follower restart [solr]

2024-11-21 Thread via GitHub
epugh closed pull request #2873: SOLR-17306: fix replication problem on follower restart URL: https://github.com/apache/solr/pull/2873 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific co

[PR] SOLR-17306: fix replication problem on follower restart [solr]

2024-11-20 Thread via GitHub
ds-manzinger opened a new pull request, #2873: URL: https://github.com/apache/solr/pull/2873 https://issues.apache.org/jira/browse/SOLR-17306 # Description If Leader has Replication disabled - do not delete Followers data on restart # Solution Check if

Re: [PR] SOLR-17306: fix replication problem on follower restart [solr]

2024-11-20 Thread via GitHub
ds-manzinger commented on PR #2873: URL: https://github.com/apache/solr/pull/2873#issuecomment-2486175531 https://github.com/apache/solr/pull/2874 This is the Pull Request against main branch -- This is an automated message from the Apache Git Service. To respond to the message, ple

[PR] SOLR-17306: fix replication problem on follower restart [solr]

2024-11-19 Thread via GitHub
ds-manzinger opened a new pull request, #2874: URL: https://github.com/apache/solr/pull/2874 https://issues.apache.org/jira/browse/SOLR-17306 Same as https://github.com/apache/solr/pull/2873 -> but now against main branch # Description If Leader has Replicati

Re: [PR] SOLR-17306: fix replication problem on follower restart [solr]

2024-11-19 Thread via GitHub
epugh commented on PR #2873: URL: https://github.com/apache/solr/pull/2873#issuecomment-2486163564 BTW, it would be interesting if you could write a short few paragraphs type story of how you do your lifecycle with leader/folllower/replicas, your ASG etc. In https://github.com/apache/sol

Re: [PR] SOLR-17306: fix replication problem on follower restart [solr]

2024-11-19 Thread via GitHub
epugh commented on PR #2873: URL: https://github.com/apache/solr/pull/2873#issuecomment-2486155043 > Should we also submit a Pull Request against the _main_ branch? Please do open aginst _main_... Generally we commit to _main_ and then backport to branch_9x. This should go out in 9.8.

Re: [PR] SOLR-17306: fix replication problem on follower restart [solr]

2024-11-19 Thread via GitHub
ds-manzinger commented on PR #2873: URL: https://github.com/apache/solr/pull/2873#issuecomment-2486091063 @epugh First, we tried using BATS for testing (as you already mentioned in the JIRA Ticket), but it was easier to create the unit test attached to the Pull Request. We built this

Re: [PR] SOLR-17306: fix replication problem on follower restart [solr]

2024-11-19 Thread via GitHub
epugh commented on PR #2873: URL: https://github.com/apache/solr/pull/2873#issuecomment-2485945577 Could https://github.com/apache/solr/pull/1875 be augmented to test your scenario? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to Gi

Re: [PR] SOLR-17306: fix replication problem on follower restart [solr]

2024-11-19 Thread via GitHub
epugh commented on PR #2873: URL: https://github.com/apache/solr/pull/2873#issuecomment-2485943863 I am hoping someone with more confidence in this area weighs in, but if you don't get a review, please do poke me!!! -- This is an automated message from the Apache Git Service. To respond t