Re: [PR] SOLR-17256: Nuke SolrRequest set/getBasePath in 10 [solr]

2024-11-12 Thread via GitHub
gerlowskija merged PR #2852: URL: https://github.com/apache/solr/pull/2852 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apach

Re: [PR] SOLR-17256: Nuke SolrRequest set/getBasePath in 10 [solr]

2024-11-12 Thread via GitHub
gerlowskija commented on code in PR #2852: URL: https://github.com/apache/solr/pull/2852#discussion_r1838490244 ## solr/solrj/src/java/org/apache/solr/client/solrj/util/ClientUtils.java: ## @@ -66,32 +64,23 @@ public static Collection toContentStreams( * Create the full URL

Re: [PR] SOLR-17256: Nuke SolrRequest set/getBasePath in 10 [solr]

2024-11-07 Thread via GitHub
dsmiley commented on code in PR #2852: URL: https://github.com/apache/solr/pull/2852#discussion_r1833191483 ## solr/solrj/src/java/org/apache/solr/client/solrj/util/ClientUtils.java: ## @@ -66,32 +64,23 @@ public static Collection toContentStreams( * Create the full URL for

[PR] SOLR-17256: Nuke SolrRequest set/getBasePath in 10 [solr]

2024-11-07 Thread via GitHub
gerlowskija opened a new pull request, #2852: URL: https://github.com/apache/solr/pull/2852 https://issues.apache.org/jira/browse/SOLR-17256 # Description Previous PRs removed all use of getBasePath/setBasePath, but didn't remove the methods themselves to facilitate easier