github-actions[bot] commented on PR #2376:
URL: https://github.com/apache/solr/pull/2376#issuecomment-2148598887
This PR had no visible activity in the past 60 days, labeling it as stale.
Any new activity will remove the stale label. To attract more reviewers, please
tag someone or notify t
dsmiley commented on PR #2376:
URL: https://github.com/apache/solr/pull/2376#issuecomment-2030090513
> Spark should actually call the SolrZkClient.close right?
Yes.
We aren't Spark experts here, but we are Solr experts :-). If you don't know
about lifecycle matters in Spark the
amanraj2520 commented on PR #2376:
URL: https://github.com/apache/solr/pull/2376#issuecomment-2029135370
@murblanc @dsmiley So you mean that when the Spark driver JVM ends, Spark
should actually call the SolrZkClient.close right? Should it be implemented
using Shutdown Hooks?
--
This is
amanraj2520 commented on PR #2376:
URL: https://github.com/apache/solr/pull/2376#issuecomment-2029068292
Sure @murblanc @dsmiley Will check this
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to th
dsmiley commented on PR #2376:
URL: https://github.com/apache/solr/pull/2376#issuecomment-2028438789
+1 to murblanc -- SolrClient.close must be called
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
murblanc commented on PR #2376:
URL: https://github.com/apache/solr/pull/2376#issuecomment-2026945228
This changes ALL thread creations that use `SolrNamedThreadFactory`. I don't
think that's the intention.
Furthermore, `SolrZkClient` has an `isClosed` flag set from the `close()`
met
epugh commented on PR #2376:
URL: https://github.com/apache/solr/pull/2376#issuecomment-2025953055
This seems like a straightforward change, but honestly, Java and threads
terrify me, so maybe someone else could chime in?
--
This is an automated message from the Apache Git Service.
To res
amanraj2520 commented on PR #2376:
URL: https://github.com/apache/solr/pull/2376#issuecomment-2025664923
@mkhludnev @epugh Can you please review this change.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL abov
amanraj2520 opened a new pull request, #2376:
URL: https://github.com/apache/solr/pull/2376
https://issues.apache.org/jira/browse/SOLR-17220
# Description
I am submitting a SparkSql job through spark-submit. Spark version 3.3.1 and
Kyuubi version 1.8.0. I am using O
