gerlowskija merged PR #2395:
URL: https://github.com/apache/solr/pull/2395
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apach
dsmiley commented on PR #2395:
URL: https://github.com/apache/solr/pull/2395#issuecomment-2100767344
Cool; please remember to mention me in CHANGES.txt. And thanks for adding
this protection.
--
This is an automated message from the Apache Git Service.
To respond to the message, please l
gerlowskija commented on PR #2395:
URL: https://github.com/apache/solr/pull/2395#issuecomment-2100578628
Thanks for the change David - apologies for the back and forth trying to
understand what you were suggesting. I've merged your PR into this branch.
With that wrapped up, I'm going
gerlowskija commented on code in PR #2395:
URL: https://github.com/apache/solr/pull/2395#discussion_r1594022421
##
solr/core/src/java/org/apache/solr/update/processor/NumFieldLimitingUpdateRequestProcessorFactory.java:
##
@@ -0,0 +1,113 @@
+/*
+ * Licensed to the Apache Software
gerlowskija commented on code in PR #2395:
URL: https://github.com/apache/solr/pull/2395#discussion_r1594022421
##
solr/core/src/java/org/apache/solr/update/processor/NumFieldLimitingUpdateRequestProcessorFactory.java:
##
@@ -0,0 +1,113 @@
+/*
+ * Licensed to the Apache Software
gerlowskija commented on code in PR #2395:
URL: https://github.com/apache/solr/pull/2395#discussion_r1594016753
##
solr/core/src/test-files/solr/configsets/cloud-minimal-field-limiting/conf/solrconfig.xml:
##
@@ -0,0 +1,73 @@
+
+
+
+
+
+
+
+
+ ${solr.data.dir:}
+
+
+
+
+ $
dsmiley commented on PR #2395:
URL: https://github.com/apache/solr/pull/2395#issuecomment-2097012109
See https://github.com/gerlowskija/solr/pull/5 for a commit that makes a
large simplification:
* No NumFieldsMonitor
* No named URP; anonymous class is fine (and less code)
* URP nee
dsmiley commented on code in PR #2395:
URL: https://github.com/apache/solr/pull/2395#discussion_r1591513535
##
solr/core/src/java/org/apache/solr/update/processor/NumFieldLimitingUpdateRequestProcessorFactory.java:
##
@@ -0,0 +1,113 @@
+/*
+ * Licensed to the Apache Software Fou
gerlowskija commented on code in PR #2395:
URL: https://github.com/apache/solr/pull/2395#discussion_r1591039849
##
solr/core/src/java/org/apache/solr/update/processor/NumFieldLimitingUpdateRequestProcessorFactory.java:
##
@@ -0,0 +1,113 @@
+/*
+ * Licensed to the Apache Software
gerlowskija commented on code in PR #2395:
URL: https://github.com/apache/solr/pull/2395#discussion_r1591064705
##
solr/core/src/java/org/apache/solr/update/processor/NumFieldLimitingUpdateRequestProcessor.java:
##
@@ -0,0 +1,83 @@
+/*
+ * Licensed to the Apache Software Foundat
gerlowskija commented on code in PR #2395:
URL: https://github.com/apache/solr/pull/2395#discussion_r1591039849
##
solr/core/src/java/org/apache/solr/update/processor/NumFieldLimitingUpdateRequestProcessorFactory.java:
##
@@ -0,0 +1,113 @@
+/*
+ * Licensed to the Apache Software
dsmiley commented on code in PR #2395:
URL: https://github.com/apache/solr/pull/2395#discussion_r1589670077
##
solr/core/src/java/org/apache/solr/update/processor/NumFieldLimitingUpdateRequestProcessorFactory.java:
##
@@ -0,0 +1,113 @@
+/*
+ * Licensed to the Apache Software Fou
dsmiley commented on code in PR #2395:
URL: https://github.com/apache/solr/pull/2395#discussion_r1589657516
##
solr/core/src/java/org/apache/solr/update/processor/NumFieldLimitingUpdateRequestProcessorFactory.java:
##
@@ -0,0 +1,113 @@
+/*
+ * Licensed to the Apache Software Fou
dsmiley commented on code in PR #2395:
URL: https://github.com/apache/solr/pull/2395#discussion_r1589647578
##
solr/core/src/java/org/apache/solr/update/processor/NumFieldsMonitor.java:
##
@@ -0,0 +1,56 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or mor
dsmiley commented on code in PR #2395:
URL: https://github.com/apache/solr/pull/2395#discussion_r1589645861
##
solr/core/src/test-files/solr/configsets/cloud-minimal-field-limiting/conf/solrconfig.xml:
##
@@ -0,0 +1,73 @@
+
+
+
+
+
+
+
+
+ ${solr.data.dir:}
+
+
+
+
+ ${tes
gerlowskija commented on code in PR #2395:
URL: https://github.com/apache/solr/pull/2395#discussion_r1589189040
##
solr/core/src/java/org/apache/solr/update/processor/NumFieldLimitingUpdateRequestProcessorFactory.java:
##
@@ -0,0 +1,113 @@
+/*
+ * Licensed to the Apache Software
gerlowskija commented on code in PR #2395:
URL: https://github.com/apache/solr/pull/2395#discussion_r1589268556
##
solr/core/src/java/org/apache/solr/update/processor/NumFieldsMonitor.java:
##
@@ -0,0 +1,56 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or
gerlowskija commented on PR #2395:
URL: https://github.com/apache/solr/pull/2395#issuecomment-2093110049
Thanks for the re-review @dsmiley . Pending feedback from others I'm going
to stick with the NumFieldMonitor approach (more details
[here](https://github.com/apache/solr/pull/2395#discu
gerlowskija commented on code in PR #2395:
URL: https://github.com/apache/solr/pull/2395#discussion_r1589215019
##
solr/core/src/java/org/apache/solr/update/processor/NumFieldsMonitor.java:
##
@@ -0,0 +1,56 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or
dsmiley commented on code in PR #2395:
URL: https://github.com/apache/solr/pull/2395#discussion_r1586827784
##
solr/core/src/java/org/apache/solr/update/processor/NumFieldLimitingUpdateRequestProcessor.java:
##
@@ -0,0 +1,83 @@
+/*
+ * Licensed to the Apache Software Foundation
gerlowskija commented on PR #2395:
URL: https://github.com/apache/solr/pull/2395#issuecomment-2086978057
Alright, I've removed a lot of the leadership and shard checking logic based
on review feedback. I think this should be ready to go, unless you have
remaining concerns @dsmiley ?
gerlowskija commented on code in PR #2395:
URL: https://github.com/apache/solr/pull/2395#discussion_r1585300753
##
solr/core/src/java/org/apache/solr/update/processor/NumFieldLimitingUpdateRequestProcessor.java:
##
@@ -0,0 +1,140 @@
+/*
+ * Licensed to the Apache Software Founda
dsmiley commented on code in PR #2395:
URL: https://github.com/apache/solr/pull/2395#discussion_r1567989670
##
solr/core/src/java/org/apache/solr/update/processor/NumFieldLimitingUpdateRequestProcessor.java:
##
@@ -0,0 +1,140 @@
+/*
+ * Licensed to the Apache Software Foundation
gerlowskija commented on PR #2395:
URL: https://github.com/apache/solr/pull/2395#issuecomment-2059268487
> I don't like the complexity in this URP relating to tolerance of where the
URP is placed in the chain; I'd feel better if the URP were simplified from
that concern and we expect the us
dsmiley commented on PR #2395:
URL: https://github.com/apache/solr/pull/2395#issuecomment-2050095834
I don't like the complexity in this URP relating to tolerance of where the
URP is placed in the chain; I'd feel better if the URP were simplified from
that concern and we expect the user to
gerlowskija commented on PR #2395:
URL: https://github.com/apache/solr/pull/2395#issuecomment-2049901831
> Sorry if I rained on your parade, attempting to get this in by EOW.
Oh no worries; there's no particular rush. That was just how long I was
planning to wait if no one commented
gerlowskija commented on code in PR #2395:
URL: https://github.com/apache/solr/pull/2395#discussion_r1560999237
##
solr/core/src/java/org/apache/solr/update/processor/NumFieldLimitingUpdateRequestProcessor.java:
##
@@ -0,0 +1,140 @@
+/*
+ * Licensed to the Apache Software Founda
gerlowskija commented on code in PR #2395:
URL: https://github.com/apache/solr/pull/2395#discussion_r1561009284
##
solr/core/src/java/org/apache/solr/update/processor/NumFieldLimitingUpdateRequestProcessorFactory.java:
##
@@ -0,0 +1,110 @@
+/*
+ * Licensed to the Apache Software
dsmiley commented on PR #2395:
URL: https://github.com/apache/solr/pull/2395#issuecomment-2048498024
Sorry if I rained on your parade, attempting to get this in by EOW.
I like the idea of having checks like this by default but I'd like Solr to
have such built-in plugins simply be regi
epugh commented on code in PR #2395:
URL: https://github.com/apache/solr/pull/2395#discussion_r1559751361
##
solr/core/src/java/org/apache/solr/update/processor/NumFieldsMonitor.java:
##
@@ -0,0 +1,57 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
gerlowskija commented on PR #2395:
URL: https://github.com/apache/solr/pull/2395#issuecomment-2047973430
This should all be ready to go: I've added unit and integration tests,
`./gradlew test` passes, there's ref-guide coverage and decent Javadocs, etc.
I'll aim to merge EOW, absent any fe
gerlowskija commented on PR #2395:
URL: https://github.com/apache/solr/pull/2395#issuecomment-2045508653
In a sample solrconfig.xml, configuration for the proposed URP would look
like:
```
123
...
```
--
This is an automated message from the Apache
gerlowskija commented on PR #2395:
URL: https://github.com/apache/solr/pull/2395#issuecomment-2045498246
Still TBD - additional tests, ref-guide docs.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
gerlowskija opened a new pull request, #2395:
URL: https://github.com/apache/solr/pull/2395
https://issues.apache.org/jira/browse/SOLR-17192
# Description
Solr isn't infinitely scalable when it comes to the number of fields in each
core/collection. Most deployments start to exp
34 matches
Mail list logo
