epugh merged PR #2321:
URL: https://github.com/apache/solr/pull/2321
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
rahulgoswami commented on PR #2321:
URL: https://github.com/apache/solr/pull/2321#issuecomment-1971794045
And thanks for taking time to review this Eric!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
rahulgoswami commented on PR #2321:
URL: https://github.com/apache/solr/pull/2321#issuecomment-1971788547
Yep that was the last bit. Good to go from my side unless there are
additional comments.
--
This is an automated message from the Apache Git Service.
To respond to the message, please
epugh commented on PR #2321:
URL: https://github.com/apache/solr/pull/2321#issuecomment-1971778835
Looking good...I see additional fix... I am running the tests... Let
me know when you feel it's "done done" ;-). and if the tests pass I'll commit.
--
This is an automated message f
epugh commented on code in PR #2321:
URL: https://github.com/apache/solr/pull/2321#discussion_r1508063854
##
solr/solrj-streaming/src/java/org/apache/solr/client/solrj/io/stream/expr/StreamExpressionParser.java:
##
@@ -132,17 +132,17 @@ private static StreamExpressionNamedParame
rahulgoswami commented on code in PR #2321:
URL: https://github.com/apache/solr/pull/2321#discussion_r1506927577
##
solr/solrj-streaming/src/java/org/apache/solr/client/solrj/io/stream/expr/StreamExpressionParser.java:
##
@@ -132,15 +132,12 @@ private static StreamExpressionName
epugh commented on code in PR #2321:
URL: https://github.com/apache/solr/pull/2321#discussion_r1506788112
##
solr/solrj-streaming/src/java/org/apache/solr/client/solrj/io/stream/expr/StreamExpressionParser.java:
##
@@ -132,15 +132,12 @@ private static StreamExpressionNamedParame
rahulgoswami opened a new pull request, #2321:
URL: https://github.com/apache/solr/pull/2321
https://issues.apache.org/jira/browse/SOLR-17186
# Description
StreamExpressionParser today replaces ` with " indiscriminately which can
break queries where the tokens thems
