Re: [PR] SOLR-17120: handle null value when merging partials [solr]

2024-01-24 Thread via GitHub
cpoerschke merged PR #2214: URL: https://github.com/apache/solr/pull/2214 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache

Re: [PR] SOLR-17120: handle null value when merging partials [solr]

2024-01-23 Thread via GitHub
cpoerschke commented on PR #2214: URL: https://github.com/apache/solr/pull/2214#issuecomment-1906437975 > LGTM - do you want to handle merging @cpoerschke , or should I? Don't want to step on your toes here... Thanks @gerlowskija - I'm happy to handle the merge and cherry-picking to

Re: [PR] SOLR-17120: handle null value when merging partials [solr]

2024-01-23 Thread via GitHub
gerlowskija commented on code in PR #2214: URL: https://github.com/apache/solr/pull/2214#discussion_r1463400754 ## solr/CHANGES.txt: ## @@ -164,6 +164,9 @@ Bug Fixes * SOLR-17090: The v2 "delete alias" API no longer errantly returns a 405 status code (Jason Gerlowski) +* S

Re: [PR] SOLR-17120: handle null value when merging partials [solr]

2024-01-23 Thread via GitHub
gerlowskija commented on PR #2214: URL: https://github.com/apache/solr/pull/2214#issuecomment-1906214351 > 21 tests failed, all of which were in org.apache.solr.s3.S3BackupRepositoryTest or org.apache.solr.s3.S3OutputStreamTest Solr has some test-flakiness issues, and the S3 tests ar

Re: [PR] SOLR-17120: handle null value when merging partials [solr]

2024-01-23 Thread via GitHub
cpoerschke commented on code in PR #2214: URL: https://github.com/apache/solr/pull/2214#discussion_r1463320201 ## solr/CHANGES.txt: ## @@ -164,6 +164,9 @@ Bug Fixes * SOLR-17090: The v2 "delete alias" API no longer errantly returns a 405 status code (Jason Gerlowski) +* SO

[PR] SOLR-17120: handle null value when merging partials [solr]

2024-01-22 Thread via GitHub
eukaryote opened a new pull request, #2214: URL: https://github.com/apache/solr/pull/2214 Avoid a `NullPointerException` that can occur under some circumstances when performing multiple partial updates of the same document in separate requests using `commitWithin`. https://issues.apa