Re: [PR] SOLR-17109: Give security manager explicit read access to sharedLib [solr]

2024-06-09 Thread via GitHub
epugh merged PR #2172: URL: https://github.com/apache/solr/pull/2172 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org

Re: [PR] SOLR-17109: Give security manager explicit read access to sharedLib [solr]

2024-06-09 Thread via GitHub
epugh commented on PR #2172: URL: https://github.com/apache/solr/pull/2172#issuecomment-2156625490 https://issues.apache.org/jira/browse/SOLR-17109 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

Re: [PR] SOLR-17109: Give security manager explicit read access to sharedLib [solr]

2024-06-09 Thread via GitHub
epugh commented on PR #2172: URL: https://github.com/apache/solr/pull/2172#issuecomment-2156625293 I wish we had some bats style tests for these things ;-). I'm going to merge this when the tests finish. -- This is an automated message from the Apache Git Service. To respond to the mess

Re: [PR] SOLR-17109: Give security manager explicit read access to sharedLib [solr]

2024-05-15 Thread via GitHub
epugh commented on PR #2172: URL: https://github.com/apache/solr/pull/2172#issuecomment-2112502657 > I'm fine with merging this. @janhoy's comment is valid though, it would cause issues if `solr.sharedLib` has more than one directory do you want me to do it? Or I can leave it up to

Re: [PR] SOLR-17109: Give security manager explicit read access to sharedLib [solr]

2024-05-15 Thread via GitHub
tflobbe commented on PR #2172: URL: https://github.com/apache/solr/pull/2172#issuecomment-2112460299 I'm fine with merging this. @janhoy's comment is valid though, it would cause issues if `solr.sharedLib` has more than one directory -- This is an automated message from the Apache Git Ser

Re: [PR] SOLR-17109: Give security manager explicit read access to sharedLib [solr]

2024-05-15 Thread via GitHub
epugh commented on PR #2172: URL: https://github.com/apache/solr/pull/2172#issuecomment-2112425839 Also, @dsmiley looks like you approved this change, can we go ahead and get it merged? -- This is an automated message from the Apache Git Service. To respond to the message, please log

Re: [PR] SOLR-17109: Give security manager explicit read access to sharedLib [solr]

2024-05-15 Thread via GitHub
epugh commented on PR #2172: URL: https://github.com/apache/solr/pull/2172#issuecomment-2112421629 Can someone explain the future of security manager in Java to me? My understanding is that it is going away (and no replacement??)... So, wouldn't it be better just to deprecate the securi

Re: [PR] SOLR-17109: Give security manager explicit read access to sharedLib [solr]

2024-05-14 Thread via GitHub
github-actions[bot] commented on PR #2172: URL: https://github.com/apache/solr/pull/2172#issuecomment-2111347562 This PR had no visible activity in the past 60 days, labeling it as stale. Any new activity will remove the stale label. To attract more reviewers, please tag someone or notify t

Re: [PR] SOLR-17109: Give security manager explicit read access to sharedLib [solr]

2024-03-06 Thread via GitHub
github-actions[bot] commented on PR #2172: URL: https://github.com/apache/solr/pull/2172#issuecomment-1982069672 This PR had no visible activity in the past 60 days, labeling it as stale. Any new activity will remove the stale label. To attract more reviewers, please tag someone or notify t

Re: [PR] SOLR-17109: Give security manager explicit read access to sharedLib [solr]

2024-01-03 Thread via GitHub
dsmiley commented on code in PR #2172: URL: https://github.com/apache/solr/pull/2172#discussion_r1441384176 ## solr/server/etc/security.policy: ## @@ -219,6 +219,9 @@ grant { permission java.io.FilePermission "${solr.allowPaths}", "read,write,delete,readlink"; permission

Re: [PR] SOLR-17109: Give security manager explicit read access to sharedLib [solr]

2024-01-03 Thread via GitHub
janhoy commented on code in PR #2172: URL: https://github.com/apache/solr/pull/2172#discussion_r1440772945 ## solr/server/etc/security.policy: ## @@ -219,6 +219,9 @@ grant { permission java.io.FilePermission "${solr.allowPaths}", "read,write,delete,readlink"; permission j

Re: [PR] SOLR-17109: Give security manager explicit read access to sharedLib [solr]

2024-01-03 Thread via GitHub
tflobbe commented on code in PR #2172: URL: https://github.com/apache/solr/pull/2172#discussion_r1440641745 ## solr/server/etc/security.policy: ## @@ -219,6 +219,9 @@ grant { permission java.io.FilePermission "${solr.allowPaths}", "read,write,delete,readlink"; permission

Re: [PR] SOLR-17109: Give security manager explicit read access to sharedLib [solr]

2024-01-02 Thread via GitHub
janhoy commented on code in PR #2172: URL: https://github.com/apache/solr/pull/2172#discussion_r143379 ## solr/server/etc/security.policy: ## @@ -219,6 +219,9 @@ grant { permission java.io.FilePermission "${solr.allowPaths}", "read,write,delete,readlink"; permission j

[PR] SOLR-17109: Give security manager explicit read access to sharedLib [solr]

2024-01-02 Thread via GitHub
tflobbe opened a new pull request, #2172: URL: https://github.com/apache/solr/pull/2172 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: