Re: [PR] SOLR-17106: LBSolrClient - Make zombie ping checks configurable [solr]

2024-07-22 Thread via GitHub
github-actions[bot] commented on PR #2160: URL: https://github.com/apache/solr/pull/2160#issuecomment-2244009807 This PR has had no activity for 60 days and is now labeled as stale. Any new activity or converting it to draft will remove the stale label. To attract more reviewers, please t

Re: [PR] SOLR-17106: LBSolrClient - Make zombie ping checks configurable [solr]

2024-05-15 Thread via GitHub
dsmiley commented on code in PR #2160: URL: https://github.com/apache/solr/pull/2160#discussion_r1601881299 ## solr/solrj/src/java/org/apache/solr/client/solrj/impl/LBSolrClient.java: ## @@ -480,35 +488,70 @@ public RequestWriter getRequestWriter() { return requestWriter;

Re: [PR] SOLR-17106: LBSolrClient - Make zombie ping checks configurable [solr]

2024-05-15 Thread via GitHub
epugh commented on code in PR #2160: URL: https://github.com/apache/solr/pull/2160#discussion_r1601674762 ## solr/solrj/src/java/org/apache/solr/client/solrj/impl/LBHttp2SolrClient.java: ## @@ -281,6 +298,37 @@ public LBHttp2SolrClient.Builder setAliveCheckInterval(int aliveChe

Re: [PR] SOLR-17106: LBSolrClient - Make zombie ping checks configurable [solr]

2024-05-15 Thread via GitHub
dsmiley commented on PR #2160: URL: https://github.com/apache/solr/pull/2160#issuecomment-2112567149 Aparna, are we just missing use of EnvUtils here? I know we've taken this change as-is (in our fork) but even we don't have that, thus it's hard to actually _use_ the changes configured her

Re: [PR] SOLR-17106: LBSolrClient - Make zombie ping checks configurable [solr]

2024-05-14 Thread via GitHub
github-actions[bot] commented on PR #2160: URL: https://github.com/apache/solr/pull/2160#issuecomment-2111347606 This PR had no visible activity in the past 60 days, labeling it as stale. Any new activity will remove the stale label. To attract more reviewers, please tag someone or notify t

[PR] SOLR-17106: LBSolrClient - Make zombie ping checks configurable [solr]

2023-12-18 Thread via GitHub
aparnasuresh85 opened a new pull request, #2160: URL: https://github.com/apache/solr/pull/2160 https://issues.apache.org/jira/browse/SOLR-17106 # Description Please provide a short description of the changes you're making with this pull request. The issue involve