Re: [PR] SOLR-17097: Upgrade Solr to use Lucene 9.9.1 [solr]

2024-01-25 Thread via GitHub
NazerkeBS commented on PR #2176: URL: https://github.com/apache/solr/pull/2176#issuecomment-1910469447 > FYI I've tried out the Solr-with-local-Lucene documentation steps -- #2223 tweaks are a side effect -- to confirm and have confirmed that [apache/lucene#13014](https://github.com/apache/

Re: [PR] SOLR-17097: Upgrade Solr to use Lucene 9.9.1 [solr]

2024-01-25 Thread via GitHub
cpoerschke commented on PR #2176: URL: https://github.com/apache/solr/pull/2176#issuecomment-1910399161 FYI I've tried out the Solr-with-local-Lucene documentation steps -- #2223 tweaks are a side effect -- to confirm and have confirmed that https://github.com/apache/lucene/pull/13014 solve

Re: [PR] SOLR-17097: Upgrade Solr to use Lucene 9.9.1 [solr]

2024-01-16 Thread via GitHub
cpoerschke commented on PR #2176: URL: https://github.com/apache/solr/pull/2176#issuecomment-1893752822 cross-referencing w.r.t. the `TestScoreJoinQPNoScore#testRandomJoin` failures: * https://lists.apache.org/thread/ms65gkmm86cpp5ntdo555ob8mrgg64o5 thread on the Lucene Dev mailing list

Re: [PR] SOLR-17097: Upgrade Solr to use Lucene 9.9.1 [solr]

2024-01-11 Thread via GitHub
NazerkeBS commented on code in PR #2176: URL: https://github.com/apache/solr/pull/2176#discussion_r1448955485 ## solr/core/src/java/org/apache/solr/index/SlowCompositeReaderWrapper.java: ## @@ -109,9 +109,10 @@ public static LeafReader wrap(IndexReader reader) throws IOExceptio

Re: [PR] SOLR-17097: Upgrade Solr to use Lucene 9.9.1 [solr]

2024-01-10 Thread via GitHub
psalagnac commented on code in PR #2176: URL: https://github.com/apache/solr/pull/2176#discussion_r1447433615 ## solr/core/src/java/org/apache/solr/index/SlowCompositeReaderWrapper.java: ## @@ -109,9 +109,10 @@ public static LeafReader wrap(IndexReader reader) throws IOExceptio

Re: [PR] SOLR-17097: Upgrade Solr to use Lucene 9.9.1 [solr]

2024-01-09 Thread via GitHub
cpoerschke commented on code in PR #2176: URL: https://github.com/apache/solr/pull/2176#discussion_r1446410422 ## solr/core/src/test/org/apache/solr/search/TestSolrQueryParser.java: ## @@ -247,9 +247,16 @@ public void testSyntax() throws Exception { SchemaField foo_dt = h

Re: [PR] SOLR-17097: Upgrade Solr to use Lucene 9.9.1 [solr]

2024-01-09 Thread via GitHub
cpoerschke commented on PR #2176: URL: https://github.com/apache/solr/pull/2176#issuecomment-1883502943 > `TestSolrQueryParser#testSyntax `- re-run it a few times locally , surprisingly it passed then failed, passed, failed; somewhat flaky. Was able to reproduce the failure locally wi

Re: [PR] SOLR-17097: Upgrade Solr to use Lucene 9.9.1 [solr]

2024-01-09 Thread via GitHub
cpoerschke commented on code in PR #2176: URL: https://github.com/apache/solr/pull/2176#discussion_r1446374641 ## solr/core/src/java/org/apache/solr/index/SlowCompositeReaderWrapper.java: ## @@ -111,7 +111,12 @@ public static LeafReader wrap(IndexReader reader) throws IOExcepti

Re: [PR] SOLR-17097: Upgrade Solr to use Lucene 9.9.1 [solr]

2024-01-09 Thread via GitHub
cpoerschke commented on code in PR #2176: URL: https://github.com/apache/solr/pull/2176#discussion_r1446372088 ## solr/core/src/java/org/apache/solr/index/SlowCompositeReaderWrapper.java: ## @@ -97,7 +97,7 @@ public static LeafReader wrap(IndexReader reader) throws IOException

Re: [PR] SOLR-17097: Upgrade Solr to use Lucene 9.9.1 [solr]

2024-01-09 Thread via GitHub
cpoerschke commented on code in PR #2176: URL: https://github.com/apache/solr/pull/2176#discussion_r1446361971 ## solr/core/src/java/org/apache/solr/handler/component/QueryComponent.java: ## @@ -497,7 +498,8 @@ protected int compare(int i, int j) { // :TODO: would be

Re: [PR] SOLR-17097: Upgrade Solr to use Lucene 9.9.1 [solr]

2024-01-04 Thread via GitHub
NazerkeBS commented on PR #2176: URL: https://github.com/apache/solr/pull/2176#issuecomment-1877411210 > It's great that we are working to stay up to date with Lucene! Looks like two of the tests are failing? `TestSolrQueryParser#testSyntax `- re-run it a few times locally , surprisi

Re: [PR] SOLR-17097: Upgrade Solr to use Lucene 9.9.1 [solr]

2024-01-04 Thread via GitHub
epugh commented on PR #2176: URL: https://github.com/apache/solr/pull/2176#issuecomment-1877156966 Looks like two of the tests are failing? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[PR] SOLR-17097: Upgrade Solr to use Lucene 9.9.1 [solr]

2024-01-04 Thread via GitHub
NazerkeBS opened a new pull request, #2176: URL: https://github.com/apache/solr/pull/2176 *https://issues.apache.org/jira/browse/SOLR-17097 # Description Upgrade Solr to use Lucene 9.9.1 # Solution Please provide a short description of the approach take