Re: [PR] SOLR-17096: Cluster Singleton plugin support in solr.xml [solr]

2024-01-17 Thread via GitHub
dsmiley merged PR #2126: URL: https://github.com/apache/solr/pull/2126 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.or

Re: [PR] SOLR-17096: Cluster Singleton plugin support in solr.xml [solr]

2024-01-17 Thread via GitHub
dsmiley commented on PR #2126: URL: https://github.com/apache/solr/pull/2126#issuecomment-1897365952 The failure is unrelated; see https://github.com/apache/solr/pull/2204 for a fix. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to G

Re: [PR] SOLR-17096: Cluster Singleton plugin support in solr.xml [solr]

2024-01-17 Thread via GitHub
dsmiley commented on PR #2126: URL: https://github.com/apache/solr/pull/2126#issuecomment-1896288802 There seems to be a test failure. Once that's worked out, I plan to merge! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub a

Re: [PR] SOLR-17096: Cluster Singleton plugin support in solr.xml [solr]

2024-01-16 Thread via GitHub
janhoy commented on code in PR #2126: URL: https://github.com/apache/solr/pull/2126#discussion_r1453182213 ## solr/core/src/java/org/apache/solr/api/ContainerPluginsRegistry.java: ## @@ -75,6 +73,8 @@ public class ContainerPluginsRegistry implements ClusterPropertiesListener,

Re: [PR] SOLR-17096: Cluster Singleton plugin support in solr.xml [solr]

2024-01-15 Thread via GitHub
dsmiley commented on code in PR #2126: URL: https://github.com/apache/solr/pull/2126#discussion_r1452857904 ## solr/core/src/java/org/apache/solr/api/ContainerPluginsRegistry.java: ## @@ -75,6 +73,8 @@ public class ContainerPluginsRegistry implements ClusterPropertiesListener,

Re: [PR] SOLR-17096: Cluster Singleton plugin support in solr.xml [solr]

2024-01-15 Thread via GitHub
dsmiley commented on code in PR #2126: URL: https://github.com/apache/solr/pull/2126#discussion_r1452677893 ## solr/core/src/java/org/apache/solr/api/ClusterPluginsSourceConfigurator.java: ## @@ -0,0 +1,50 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or