Re: [PR] SOLR-17079: Allow to declare replica placement plugins in solr.xml [solr]

2023-11-20 Thread via GitHub
cpoerschke commented on PR #2071: URL: https://github.com/apache/solr/pull/2071#issuecomment-1819085178 > ... Btw, there are tests in `TestXLSXResponseWriter` failing in CI, but I cannot reproduce locally (and it does not really seem related to my change). Filed https://issues.apache.

Re: [PR] SOLR-17079: Allow to declare replica placement plugins in solr.xml [solr]

2023-11-20 Thread via GitHub
pvcnt commented on PR #2071: URL: https://github.com/apache/solr/pull/2071#issuecomment-1818435207 Ooops, sorry about that. Is there a view of all tests failures in a CI run? Or is there a way to configure that? I know that in Jenkins we can have a specific view of all failing tests instead

Re: [PR] SOLR-17079: Allow to declare replica placement plugins in solr.xml [solr]

2023-11-19 Thread via GitHub
dsmiley commented on PR #2071: URL: https://github.com/apache/solr/pull/2071#issuecomment-1818326814 The XLSX issue is only on Crave pertaining to the JDK used there being somewhat incomplete. I reported it and it should be fixed soon if not already. So I merged this but I should hav

Re: [PR] SOLR-17079: Allow to declare replica placement plugins in solr.xml [solr]

2023-11-19 Thread via GitHub
dsmiley merged PR #2071: URL: https://github.com/apache/solr/pull/2071 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.or

Re: [PR] SOLR-17079: Allow to declare replica placement plugins in solr.xml [solr]

2023-11-16 Thread via GitHub
pvcnt commented on PR #2071: URL: https://github.com/apache/solr/pull/2071#issuecomment-181401 I added a line in CHANGES.txt and a precision in documentation about the class attribute in solr.xml. Btw, there are tests in `TestXLSXResponseWriter` failing in CI, but I cannot reproduce loc