Re: [PR] SOLR-17077: Don't cancel twice when rejoining shard leader election [solr]

epugh commented on PR #2084: URL: https://github.com/apache/solr/pull/2084#issuecomment-2331945449 > I don't see any reason this could not be ported. @dsmiley I'm not sure of the process here. Is a new Jira required? If a backport isn't a major effort then generally we don't have new

Re: [PR] SOLR-17077: Don't cancel twice when rejoining shard leader election [solr]

mtchorz commented on PR #2084: URL: https://github.com/apache/solr/pull/2084#issuecomment-2331690979 @psalagnac @dsmiley are there any chances that the changes could be back ported to next 9.x version? We are facing similar issues with solr 9.5 -- This is an automated message from the Apa

Re: [PR] SOLR-17077: Don't cancel twice when rejoining shard leader election [solr]

psalagnac commented on PR #2084: URL: https://github.com/apache/solr/pull/2084#issuecomment-1843427630 Yes, just main is fine. I want to follow-up on this work with other cleanups in leader election code. I don't think it is worth to backport them to 9x. -- This is an automated message

Re: [PR] SOLR-17077: Don't cancel twice when rejoining shard leader election [solr]

dsmiley commented on PR #2084: URL: https://github.com/apache/solr/pull/2084#issuecomment-1841766856 By entering this CHANGES.txt into the 10.0 release section, it means you believe it should not be back ported to 9x. Is that what you meant or was that accidental? I'll move it and backpor

Re: [PR] SOLR-17077: Don't cancel twice when rejoining shard leader election [solr]

dsmiley merged PR #2084: URL: https://github.com/apache/solr/pull/2084 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.or

Re: [PR] SOLR-17077: Don't cancel twice when rejoining shard leader election [solr]

psalagnac commented on PR #2084: URL: https://github.com/apache/solr/pull/2084#issuecomment-1840992838 Thanks. I added an entry in "Improvements", but not sure whether it should go to bug "Bug Fixes". Maybe the code should have been like the from the beginning. -- This is an automated

Re: [PR] SOLR-17077: Don't cancel twice when rejoining shard leader election [solr]

dsmiley commented on PR #2084: URL: https://github.com/apache/solr/pull/2084#issuecomment-1840901629 @psalagnac can you add a CHANGES.txt entry please? In "Other" or "Improvements" depending on your point of view. Try to both be brief and communicate the scope/impact -- kind of hard somet

Re: [PR] SOLR-17077: Don't cancel twice when rejoining shard leader election [solr]

psalagnac commented on code in PR #2084: URL: https://github.com/apache/solr/pull/2084#discussion_r1414031688 ## solr/solrj/src/java/org/apache/solr/client/solrj/request/beans/RejoinLeaderElectionPayload.java: ## @@ -26,13 +26,9 @@ public class RejoinLeaderElectionPayload implem

Re: [PR] SOLR-17077: Don't cancel twice when rejoining shard leader election [solr]

psalagnac commented on code in PR #2084: URL: https://github.com/apache/solr/pull/2084#discussion_r1414031688 ## solr/solrj/src/java/org/apache/solr/client/solrj/request/beans/RejoinLeaderElectionPayload.java: ## @@ -26,13 +26,9 @@ public class RejoinLeaderElectionPayload implem

Re: [PR] SOLR-17077: Don't cancel twice when rejoining shard leader election [solr]

dsmiley commented on code in PR #2084: URL: https://github.com/apache/solr/pull/2084#discussion_r1399267463 ## solr/solrj/src/java/org/apache/solr/client/solrj/request/beans/RejoinLeaderElectionPayload.java: ## @@ -26,13 +26,9 @@ public class RejoinLeaderElectionPayload implemen

[PR] SOLR-17077: Don't cancel twice when rejoining shard leader election [solr]

psalagnac opened a new pull request, #2084: URL: https://github.com/apache/solr/pull/2084 https://issues.apache.org/jira/browse/SOLR-17077 # Description When we invoke `REJOINELECTION` command on a replica, the replica must first leave its current election position