justinrsweeney commented on PR #2076:
URL: https://github.com/apache/solr/pull/2076#issuecomment-2088534839
Thanks for the reminder, will make sure next time!
On Wed, May 1, 2024 at 10:06 AM David Smiley ***@***.***>
wrote:
> Just a little reminder... when squash-merging, rem
dsmiley commented on PR #2076:
URL: https://github.com/apache/solr/pull/2076#issuecomment-2088515065
Just a little reminder... when squash-merging, remember to edit the commit
message so it's cleaned up to reflect the final result in totality; it's almost
always necessary. Should not refer
justinrsweeney merged PR #2076:
URL: https://github.com/apache/solr/pull/2076
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.ap
patsonluk commented on code in PR #2076:
URL: https://github.com/apache/solr/pull/2076#discussion_r1399517132
##
solr/core/src/java/org/apache/solr/cluster/placement/plugins/OrderedNodePlacementPlugin.java:
##
@@ -515,6 +521,7 @@ public final void removeReplica(Replica replica)
patsonluk commented on code in PR #2076:
URL: https://github.com/apache/solr/pull/2076#discussion_r1399517132
##
solr/core/src/java/org/apache/solr/cluster/placement/plugins/OrderedNodePlacementPlugin.java:
##
@@ -515,6 +521,7 @@ public final void removeReplica(Replica replica)
patsonluk commented on code in PR #2076:
URL: https://github.com/apache/solr/pull/2076#discussion_r1394981238
##
solr/core/src/java/org/apache/solr/cluster/placement/plugins/OrderedNodePlacementPlugin.java:
##
@@ -515,6 +521,7 @@ public final void removeReplica(Replica replica)
patsonluk commented on code in PR #2076:
URL: https://github.com/apache/solr/pull/2076#discussion_r1394983063
##
solr/core/src/java/org/apache/solr/cluster/placement/plugins/OrderedNodePlacementPlugin.java:
##
@@ -404,20 +404,25 @@ public abstract static class WeightedNode imple
patsonluk commented on code in PR #2076:
URL: https://github.com/apache/solr/pull/2076#discussion_r1394983063
##
solr/core/src/java/org/apache/solr/cluster/placement/plugins/OrderedNodePlacementPlugin.java:
##
@@ -404,20 +404,25 @@ public abstract static class WeightedNode imple
patsonluk commented on code in PR #2076:
URL: https://github.com/apache/solr/pull/2076#discussion_r1394981238
##
solr/core/src/java/org/apache/solr/cluster/placement/plugins/OrderedNodePlacementPlugin.java:
##
@@ -515,6 +521,7 @@ public final void removeReplica(Replica replica)
magibney commented on code in PR #2076:
URL: https://github.com/apache/solr/pull/2076#discussion_r1394780552
##
solr/core/src/java/org/apache/solr/cluster/placement/plugins/OrderedNodePlacementPlugin.java:
##
@@ -515,6 +521,7 @@ public final void removeReplica(Replica replica) {
patsonluk commented on PR #2076:
URL: https://github.com/apache/solr/pull/2076#issuecomment-1812984201
```
ERROR: The following test(s) have failed:
- org.apache.solr.cloud.BasicDistributedZk2Test.test (:solr:core)
Test output:
/Users/patson/src/cowpath-solr/solr/core/build/te
11 matches
Mail list logo
