gerlowskija merged PR #2201:
URL: https://github.com/apache/solr/pull/2201
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apach
gerlowskija commented on code in PR #2201:
URL: https://github.com/apache/solr/pull/2201#discussion_r1459224634
##
solr/solrj/src/java/org/apache/solr/client/solrj/request/CollectionRequiringSolrRequest.java:
##
@@ -19,13 +19,15 @@
import org.apache.solr.client.solrj.SolrReques
epugh commented on code in PR #2201:
URL: https://github.com/apache/solr/pull/2201#discussion_r1454071596
##
solr/solrj/src/java/org/apache/solr/client/solrj/impl/SolrClientBuilder.java:
##
@@ -98,9 +98,9 @@ public B withFollowRedirects(boolean followRedirects) {
return get
epugh commented on code in PR #2201:
URL: https://github.com/apache/solr/pull/2201#discussion_r1454069949
##
solr/solrj/src/java/org/apache/solr/client/solrj/SolrRequest.java:
##
Review Comment:
i think this javadocs is great... to me it reads clearer...
--
This is an
dsmiley commented on code in PR #2201:
URL: https://github.com/apache/solr/pull/2201#discussion_r1453961978
##
solr/solrj/src/java/org/apache/solr/client/solrj/impl/CloudLegacySolrClient.java:
##
@@ -238,16 +238,6 @@ public Builder canUseZkACLs(boolean canUseZkACLs) {
ret
gerlowskija commented on PR #2201:
URL: https://github.com/apache/solr/pull/2201#issuecomment-1894365651
FYI @dsmiley and @epugh
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comm
gerlowskija opened a new pull request, #2201:
URL: https://github.com/apache/solr/pull/2201
https://issues.apache.org/jira/browse/SOLR-17066
# Description
"Data store" as a term, was introduced a few weeks back as a way to refer
generically to something that could be either
