dsmiley commented on code in PR #2455:
URL: https://github.com/apache/solr/pull/2455#discussion_r1624900136
##
solr/solrj/src/java/org/apache/solr/client/solrj/util/ClientUtils.java:
##
@@ -56,6 +63,51 @@ public static Collection toContentStreams(
return streams;
}
+
gerlowskija commented on code in PR #2455:
URL: https://github.com/apache/solr/pull/2455#discussion_r1624884632
##
solr/solrj/src/java/org/apache/solr/client/solrj/util/ClientUtils.java:
##
@@ -56,6 +63,51 @@ public static Collection toContentStreams(
return streams;
}
gerlowskija commented on code in PR #2455:
URL: https://github.com/apache/solr/pull/2455#discussion_r1624867836
##
solr/solrj/src/java/org/apache/solr/client/solrj/util/ClientUtils.java:
##
@@ -56,6 +63,51 @@ public static Collection toContentStreams(
return streams;
}
dsmiley commented on code in PR #2455:
URL: https://github.com/apache/solr/pull/2455#discussion_r1621361826
##
solr/solrj/src/java/org/apache/solr/client/solrj/util/ClientUtils.java:
##
@@ -56,6 +63,51 @@ public static Collection toContentStreams(
return streams;
}
+
gerlowskija merged PR #2455:
URL: https://github.com/apache/solr/pull/2455
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apach
epugh commented on PR #2455:
URL: https://github.com/apache/solr/pull/2455#issuecomment-2125737828
Does this overlap with #2473 ? WOuld be nice to get this in.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
jdyer1 commented on PR #2455:
URL: https://github.com/apache/solr/pull/2455#issuecomment-2117874056
I do not have a strong opinion here whether `buildRquestUrl` should be
public or not. I see the reasoning it gives users more flexibility. On the
other hand, it adds to the public api surfa
gerlowskija commented on PR #2455:
URL: https://github.com/apache/solr/pull/2455#issuecomment-2107307909
Thanks for the review @jdyer1 !
> but do you see end-users calling this directly? Are you sure we want it to
be public?
I made it public in support of the few SolrJ users wh
gerlowskija commented on PR #2455:
URL: https://github.com/apache/solr/pull/2455#issuecomment-2105098970
Note, this PR renames "HttpSolrClientBase.getRequestPath" (added in 9.6) to
the more accurate "getRequestUrl". When backporting to 9x we'll need to add
getRequestUrl as a separate and k
gerlowskija opened a new pull request, #2455:
URL: https://github.com/apache/solr/pull/2455
https://issues.apache.org/jira/browse/SOLR-17044
# Description
URL building logic in SolrJ is complex and is duplicated in several places.
This leads to bugs and added maintenance effor
10 matches
Mail list logo
