rahulgoswami commented on PR #2233:
URL: https://github.com/apache/solr/pull/2233#issuecomment-1927352606
Thanks for merging the PR @cpoerschke!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to th
cpoerschke merged PR #2233:
URL: https://github.com/apache/solr/pull/2233
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache
cpoerschke commented on PR #2233:
URL: https://github.com/apache/solr/pull/2233#issuecomment-1923705809
> The (unrelated) hadoop-auth test module keeps failing. Bad apple ?
I would agree that it's unrelated. Had a look at
https://github.com/apache/solr/blob/main/dev-docs/FAQ.adoc#wher
rahulgoswami commented on PR #2233:
URL: https://github.com/apache/solr/pull/2233#issuecomment-1921969595
The (unrelated) hadoop-auth test module keeps failing. Bad apple ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and u
rahulgoswami commented on PR #2233:
URL: https://github.com/apache/solr/pull/2233#issuecomment-1920583550
Incorporated review comments by @cpoerschke : 1) Added back
jakarta.inject-2.6.1.jar.sha1 removed while running ./gradlew tidy
updateLicenses check -x test
2) Added tests for new a
rahulgoswami closed pull request #2233: SOLR-17038: /admin/segments handler:
Expose the term count
URL: https://github.com/apache/solr/pull/2233
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the s
cpoerschke commented on PR #2233:
URL: https://github.com/apache/solr/pull/2233#issuecomment-1917629755
Thanks @rahulgoswami for opening this pull request!
May I suggest to undo the removal of the `.sha1` file -- it appears to be
unrelated to the handler changes (and tidy or precommit
rahulgoswami commented on PR #2233:
URL: https://github.com/apache/solr/pull/2233#issuecomment-1917627722
One odd thing that I noticed was that upon running /gradlew tidy
updateLicenses check -x test it ended up deleting
solr/licenses/jakarta.inject-2.6.1.jar.sha1 . Don't think updateLicens
rahulgoswami opened a new pull request, #2233:
URL: https://github.com/apache/solr/pull/2233
https://issues.apache.org/jira/browse/SOLR-17038
# Description
Added fieldFlags.add("termCount", terms.size()) in
SegmentsInfoRequestHandler to add termsCount when ?fieldInf
