github-actions[bot] commented on PR #1999:
URL: https://github.com/apache/solr/pull/1999#issuecomment-2060090828
This PR had no visible activity in the past 60 days, labeling it as stale.
Any new activity will remove the stale label. To attract more reviewers, please
tag someone or notify t
risdenk commented on PR #1999:
URL: https://github.com/apache/solr/pull/1999#issuecomment-1941952643
@cpoerschke https://github.com/apache/solr/pull/1510 might be helpful here.
I have a few wip prs for newer jdks
--
This is an automated message from the Apache Git Service.
To respond to t
cpoerschke commented on PR #1999:
URL: https://github.com/apache/solr/pull/1999#issuecomment-1941906981
> ... It would be interesting to think about if there was a way for Solr
`main` branch to somehow depend on the Lucene `main` branch release that jumps
the minimum Java versions all aroun
cpoerschke commented on code in PR #1999:
URL: https://github.com/apache/solr/pull/1999#discussion_r1488136630
##
versions.props:
##
@@ -49,6 +49,7 @@ org.apache.httpcomponents:httpmime=4.5.14
org.apache.kerby:*=1.0.1
org.apache.logging.log4j:*=2.21.0
org.apache.lucene:*=9.9.
epugh commented on PR #1999:
URL: https://github.com/apache/solr/pull/1999#issuecomment-1941576718
Lucene 9 requires older version of Java than the minimum required version
that OpenNLP requires. That means that this PR is pending a release of Lucene
10, and the adoption of Lucene 10 by Sol
cpoerschke commented on PR #1999:
URL: https://github.com/apache/solr/pull/1999#issuecomment-1898950454
> Feels like what we should be doing is having Solr 10 target Java 17 since
Lucene 10 will require it, and then this code goes on Solr 10, but not on Solr
9. This lets us have some more t
epugh commented on PR #1999:
URL: https://github.com/apache/solr/pull/1999#issuecomment-1898837417
Feels like what we should be doing is having Solr 10 target Java 17 since
Lucene 10 will require it, and then this code goes on Solr 10, but not on Solr
9. This lets us have some more time to
rzo1 commented on code in PR #1999:
URL: https://github.com/apache/solr/pull/1999#discussion_r1457694995
##
solr/licenses/onnxruntime-LICENSE-MIT.txt:
##
@@ -0,0 +1,21 @@
+MIT License
Review Comment:
Next opennlp will have 1.16.3 (or higher)
--
This is an automated messa
rzo1 commented on PR #1999:
URL: https://github.com/apache/solr/pull/1999#issuecomment-1898807122
> So if the classes here were built as an independent
[plugin](https://solr.apache.org/guide/solr/latest/configuration-guide/solr-plugins.html)
(with minimum Java17) and then deployed (with the
cpoerschke commented on PR #1999:
URL: https://github.com/apache/solr/pull/1999#issuecomment-1898791814
> Looking at these build failures and the error message generated, it
appears that it may be caused by us using Java 11 and OpenNLP being compiled
with Java 17?? ... Is this a deal breake
epugh commented on PR #1999:
URL: https://github.com/apache/solr/pull/1999#issuecomment-1883968479
Looking at these build failures and the error message generated, it appears
that it may be caused by us using Java 11 and OpenNLP being compiled with Java
17??
```
/home/runner/wor
epugh commented on code in PR #1999:
URL: https://github.com/apache/solr/pull/1999#discussion_r1446697110
##
solr/modules/analysis-extras/src/java/org/apache/solr/update/processor/DocumentCategorizerUpdateProcessorFactory.java:
##
@@ -0,0 +1,566 @@
+/*
+ * Licensed to the Apache
epugh commented on code in PR #1999:
URL: https://github.com/apache/solr/pull/1999#discussion_r1446696389
##
solr/licenses/onnxruntime-LICENSE-MIT.txt:
##
@@ -0,0 +1,21 @@
+MIT License
Review Comment:
I *think* we don't specify the version of onnx, so maybe we poke them to
cpoerschke commented on code in PR #1999:
URL: https://github.com/apache/solr/pull/1999#discussion_r1446447648
##
solr/licenses/onnxruntime-LICENSE-MIT.txt:
##
@@ -0,0 +1,21 @@
+MIT License
Review Comment:
part-answering own question: OpenNLP 2.3.1 uses onnxruntime 1.15.0 -
cpoerschke commented on code in PR #1999:
URL: https://github.com/apache/solr/pull/1999#discussion_r1446443017
##
solr/modules/analysis-extras/src/java/org/apache/solr/update/processor/DocumentCategorizerUpdateProcessorFactory.java:
##
@@ -0,0 +1,566 @@
+/*
+ * Licensed to the A
cpoerschke commented on code in PR #1999:
URL: https://github.com/apache/solr/pull/1999#discussion_r1446436416
##
solr/licenses/onnxruntime-LICENSE-MIT.txt:
##
@@ -0,0 +1,21 @@
+MIT License
Review Comment:
Looking up https://github.com/microsoft/onnxruntime/blob/v1.15.0/LICE
epugh commented on PR #1999:
URL: https://github.com/apache/solr/pull/1999#issuecomment-1883364525
@cpoerschke when I demoed this code at the last community meetup,
@gerlowskija asked why not to commit it, and I didn't have a super great
reason. I'd love your thoughts on this PR since you
epugh commented on PR #1999:
URL: https://github.com/apache/solr/pull/1999#issuecomment-1833889740
> Looks like a great first step! Glad that OpenNLP 2.3.1 helped move it
along.
I did a community demo yesterday, and it went well.Having 2.3.1 meant I
could remove some ugly moving
jzonthemtn commented on PR #1999:
URL: https://github.com/apache/solr/pull/1999#issuecomment-1832486680
Looks like a great first step! Glad that OpenNLP 2.3.1 helped move it along.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitH
jzonthemtn commented on code in PR #1999:
URL: https://github.com/apache/solr/pull/1999#discussion_r1409711871
##
solr/modules/analysis-extras/src/java/org/apache/solr/update/processor/DocumentCategorizerUpdateProcessorFactory.java:
##
@@ -0,0 +1,566 @@
+/*
+ * Licensed to the A
epugh commented on code in PR #1999:
URL: https://github.com/apache/solr/pull/1999#discussion_r1406194193
##
solr/packaging/test/test_opennlp.bats:
##
@@ -0,0 +1,110 @@
+#!/usr/bin/env bats
+
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor li
rzo1 commented on code in PR #1999:
URL: https://github.com/apache/solr/pull/1999#discussion_r1405818295
##
solr/packaging/test/test_opennlp.bats:
##
@@ -0,0 +1,110 @@
+#!/usr/bin/env bats
+
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor lic
22 matches
Mail list logo
