Re: [PR] SOLR-16995: Use leaderEligible property where it makes sense [solr]

2023-10-12 Thread via GitHub
dsmiley merged PR #1981: URL: https://github.com/apache/solr/pull/1981 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.or

Re: [PR] SOLR-16995: Use leaderEligible property where it makes sense [solr]

2023-10-12 Thread via GitHub
HoustonPutman commented on PR #1981: URL: https://github.com/apache/solr/pull/1981#issuecomment-1759837688 I love this. To many single-class/enum cases across the codebase, which makes adding new options much harder. -- This is an automated message from the Apache Git Service. To respond

Re: [PR] SOLR-16995: Use leaderEligible property where it makes sense [solr]

2023-10-05 Thread via GitHub
pvcnt commented on PR #1981: URL: https://github.com/apache/solr/pull/1981#issuecomment-1749203775 Failing tests are passing locally, they ma be flappers. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above t

Re: [PR] SOLR-16995: Use leaderEligible property where it makes sense [solr]

2023-10-05 Thread via GitHub
pvcnt commented on PR #1981: URL: https://github.com/apache/solr/pull/1981#issuecomment-1748843985 @dsmiley It's actually the same JIRA as #1928. It just split my end goal (making it easier to work with replica types and possibly add new ones) into several PRs. -- This is an automated me

Re: [PR] SOLR-16995: Use leaderEligible property where it makes sense [solr]

2023-10-05 Thread via GitHub
pvcnt commented on PR #1981: URL: https://github.com/apache/solr/pull/1981#issuecomment-1748367502 Related to #1928 (split this particular change into a separate PR). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[PR] SOLR-16995: Use leaderEligible property where it makes sense [solr]

2023-10-05 Thread via GitHub
pvcnt opened a new pull request, #1981: URL: https://github.com/apache/solr/pull/1981 https://issues.apache.org/jira/browse/SOLR-16995 # Description A new `leaderEligible` property was introduced on the `Replica.Type` in Solr 9 (?), but it is currently not used much