Re: [PR] SOLR-16986: log cpuTime in addition to QTime [solr]

dsmiley commented on PR #2118: URL: https://github.com/apache/solr/pull/2118#issuecomment-1930828066 I should revert this unless we get the test figured out. Otherwise the state of this JIRA is unclear. -- This is an automated message from the Apache Git Service. To respond to the messag

Re: [PR] SOLR-16986: log cpuTime in addition to QTime [solr]

dsmiley commented on PR #2118: URL: https://github.com/apache/solr/pull/2118#issuecomment-1897353526 There's an intermittent test failure (~50%) that reproducibly fails (100%) with the randomization seed. I ignored the test for now, and also incorporated a small improvement RE client lifec

Re: [PR] SOLR-16986: log cpuTime in addition to QTime [solr]

dsmiley merged PR #2118: URL: https://github.com/apache/solr/pull/2118 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.or

Re: [PR] SOLR-16986: log cpuTime in addition to QTime [solr]

dsmiley commented on PR #2118: URL: https://github.com/apache/solr/pull/2118#issuecomment-1894204371 Yes, 9.5 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe

Re: [PR] SOLR-16986: log cpuTime in addition to QTime [solr]

gbellaton commented on PR #2118: URL: https://github.com/apache/solr/pull/2118#issuecomment-1894200828 Should I add the New Feature in the 9.5.0 section of Changes.txt -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use th

Re: [PR] SOLR-16986: log cpuTime in addition to QTime [solr]

dsmiley commented on code in PR #2118: URL: https://github.com/apache/solr/pull/2118#discussion_r1453403045 ## solr/core/src/java/org/apache/solr/util/ThreadStats.java: ## @@ -0,0 +1,94 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor

Re: [PR] SOLR-16986: log cpuTime in addition to QTime [solr]

janhoy commented on code in PR #2118: URL: https://github.com/apache/solr/pull/2118#discussion_r1453177675 ## solr/core/src/java/org/apache/solr/util/ThreadStats.java: ## @@ -0,0 +1,94 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor

Re: [PR] SOLR-16986: log cpuTime in addition to QTime [solr]

dsmiley commented on code in PR #2118: URL: https://github.com/apache/solr/pull/2118#discussion_r1452859545 ## solr/core/src/java/org/apache/solr/util/ThreadStats.java: ## @@ -0,0 +1,94 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor

Re: [PR] SOLR-16986: log cpuTime in addition to QTime [solr]

gbellaton commented on code in PR #2118: URL: https://github.com/apache/solr/pull/2118#discussion_r1452330785 ## solr/core/src/test/org/apache/solr/TestCpuTimeSearch.java: ## @@ -0,0 +1,140 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contrib

Re: [PR] SOLR-16986: log cpuTime in addition to QTime [solr]

dsmiley commented on code in PR #2118: URL: https://github.com/apache/solr/pull/2118#discussion_r1448914616 ## solr/core/src/test/org/apache/solr/TestCpuTimeSearch.java: ## @@ -0,0 +1,140 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contribut

Re: [PR] SOLR-16986: log cpuTime in addition to QTime [solr]

dsmiley commented on code in PR #2118: URL: https://github.com/apache/solr/pull/2118#discussion_r1434358593 ## solr/core/src/java/org/apache/solr/util/ThreadStats.java: ## @@ -0,0 +1,94 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor

Re: [PR] SOLR-16986: log cpuTime in addition to QTime [solr]

dsmiley commented on PR #2118: URL: https://github.com/apache/solr/pull/2118#issuecomment-1844506632 > What would you think about keeping the logs as currently done but changing the response to always and only use cpuTime ? Ah; that's a nice compromise! -- This is an automated mess

Re: [PR] SOLR-16986: log cpuTime in addition to QTime [solr]

gbellaton commented on PR #2118: URL: https://github.com/apache/solr/pull/2118#issuecomment-1842954763 I think that the distinction between cpuTime and localCpuTime is useful in the logs. It allows to generate statistics from the logs that make the difference between distributed queries

Re: [PR] SOLR-16986: log cpuTime in addition to QTime [solr]

gbellaton commented on code in PR #2118: URL: https://github.com/apache/solr/pull/2118#discussion_r1417368897 ## solr/core/src/java/org/apache/solr/util/ThreadStats.java: ## @@ -0,0 +1,94 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contribut

Re: [PR] SOLR-16986: log cpuTime in addition to QTime [solr]

dsmiley commented on code in PR #2118: URL: https://github.com/apache/solr/pull/2118#discussion_r1416465264 ## solr/core/src/java/org/apache/solr/util/ThreadStats.java: ## @@ -0,0 +1,94 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor

[PR] SOLR-16986: log cpuTime in addition to QTime [solr]

gbellaton opened a new pull request, #2118: URL: https://github.com/apache/solr/pull/2118 https://issues.apache.org/jira/browse/SOLR-16986 # Description This change logs cpuTime and localCpuTime in addition to QTime. While QTime is the user time spend for a given request (dif