Re: [PR] SOLR-16743: Auto reload keystore/truststore on change [solr]

2023-11-30 Thread via GitHub
tflobbe merged PR #2100: URL: https://github.com/apache/solr/pull/2100 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.or

Re: [PR] SOLR-16743: Auto reload keystore/truststore on change [solr]

2023-11-29 Thread via GitHub
tflobbe commented on code in PR #2100: URL: https://github.com/apache/solr/pull/2100#discussion_r1409707496 ## solr/bin/solr: ## @@ -208,9 +208,17 @@ if [ -z "${SOLR_SSL_ENABLED:-}" ]; then fi if [ "$SOLR_SSL_ENABLED" == "true" ]; then SOLR_JETTY_CONFIG+=("--module=https"

Re: [PR] SOLR-16743: Auto reload keystore/truststore on change [solr]

2023-11-29 Thread via GitHub
HoustonPutman commented on code in PR #2100: URL: https://github.com/apache/solr/pull/2100#discussion_r1409515440 ## solr/bin/solr: ## @@ -208,9 +208,17 @@ if [ -z "${SOLR_SSL_ENABLED:-}" ]; then fi if [ "$SOLR_SSL_ENABLED" == "true" ]; then SOLR_JETTY_CONFIG+=("--module=ht

Re: [PR] SOLR-16743: Auto reload keystore/truststore on change [solr]

2023-11-28 Thread via GitHub
tflobbe commented on code in PR #2100: URL: https://github.com/apache/solr/pull/2100#discussion_r1408524274 ## solr/core/src/java/org/apache/solr/handler/component/HttpShardHandlerFactory.java: ## @@ -279,12 +282,20 @@ public void init(PluginInfo info) { int soTimeout =

Re: [PR] SOLR-16743: Auto reload keystore/truststore on change [solr]

2023-11-28 Thread via GitHub
HoustonPutman commented on code in PR #2100: URL: https://github.com/apache/solr/pull/2100#discussion_r1408369327 ## solr/core/src/java/org/apache/solr/handler/component/HttpShardHandlerFactory.java: ## @@ -279,12 +282,20 @@ public void init(PluginInfo info) { int soTimeout

[PR] SOLR-16743: Auto reload keystore/truststore on change [solr]

2023-11-28 Thread via GitHub
tflobbe opened a new pull request, #2100: URL: https://github.com/apache/solr/pull/2100 Marking this as a draft for now, since it's missing the documentation changes. Also, I wasn't able to test the Windows start script changes -- This is an automated message from the Apache Git Service.