epugh merged PR #2550:
URL: https://github.com/apache/solr/pull/2550
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
malliaridis commented on code in PR #2550:
URL: https://github.com/apache/solr/pull/2550#discussion_r1676978086
##
solr/solr-ref-guide/ui-src/css/tabs.css:
##
@@ -0,0 +1,103 @@
+.tabs {
Review Comment:
I would resolve this for now without adding to the file a license header
malliaridis commented on code in PR #2550:
URL: https://github.com/apache/solr/pull/2550#discussion_r1676978086
##
solr/solr-ref-guide/ui-src/css/tabs.css:
##
@@ -0,0 +1,103 @@
+.tabs {
Review Comment:
I would resolve this for now without adding to the file a license header
gerlowskija commented on code in PR #2550:
URL: https://github.com/apache/solr/pull/2550#discussion_r1676155586
##
solr/solr-ref-guide/ui-src/css/tabs.css:
##
@@ -0,0 +1,103 @@
+.tabs {
Review Comment:
Makes sense to me. Looks like you already created SOLR-17365 to cover
a
HoustonPutman commented on PR #2550:
URL: https://github.com/apache/solr/pull/2550#issuecomment-2223487564
It won't but that's ok, there's a jenkins job to do it manually.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and us
epugh commented on PR #2550:
URL: https://github.com/apache/solr/pull/2550#issuecomment-2223104446
Okay, I want to commit this. I *believe* that when we cut the new ref guide
for 9.7, that the changes to the ui bundle will then happen IIUC
--
This is an automated message from the Apa
HoustonPutman commented on PR #2550:
URL: https://github.com/apache/solr/pull/2550#issuecomment-2220946846
> It sounds like this pr is good to go, hopefully @HoustonPutman will create
the jira for adding missing licenses!
I just went through the long history of the Antora work and unf
HoustonPutman commented on PR #2550:
URL: https://github.com/apache/solr/pull/2550#issuecomment-2220924389
This should absolutely be credited in the changelog!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL ab
malliaridis commented on PR #2550:
URL: https://github.com/apache/solr/pull/2550#issuecomment-2219241785
> We don't normally credit ref guide changes but maybe should with this one
since it's improving the tooling. @malliaridis how do you want to be credited?
Your kind offer @epugh is
epugh commented on PR #2550:
URL: https://github.com/apache/solr/pull/2550#issuecomment-2218757313
It sounds like this pr is good to go, hopefully @HoustonPutman will create
the jira for adding missing licenses!
We don't normally credit ref guide changes but maybe should with this
HoustonPutman commented on code in PR #2550:
URL: https://github.com/apache/solr/pull/2550#discussion_r1670617661
##
solr/solr-ref-guide/ui-src/css/tabs.css:
##
@@ -0,0 +1,103 @@
+.tabs {
Review Comment:
I helped commit it so I should probably have a better answer, but I hav
malliaridis commented on code in PR #2550:
URL: https://github.com/apache/solr/pull/2550#discussion_r1670379638
##
solr/solr-ref-guide/ui-src/css/tabs.css:
##
@@ -0,0 +1,103 @@
+.tabs {
Review Comment:
I configured my IDE to put automatically on all files I create license
h
gerlowskija commented on code in PR #2550:
URL: https://github.com/apache/solr/pull/2550#discussion_r1669196637
##
dev-docs/ref-guide/asciidoc-syntax.adoc:
##
@@ -503,90 +503,88 @@ This means that if we want an entire section of content
to be given a specific r
TIP: For more
cpoerschke commented on code in PR #2550:
URL: https://github.com/apache/solr/pull/2550#discussion_r1668429479
##
solr/solr-ref-guide/modules/configuration-guide/pages/config-api.adoc:
##
@@ -809,6 +779,7 @@ A simple highlighter looks like this in `solrconfig.xml`
(example has
cpoerschke commented on code in PR #2550:
URL: https://github.com/apache/solr/pull/2550#discussion_r1668427293
##
dev-docs/ref-guide/asciidoc-syntax.adoc:
##
@@ -503,90 +503,88 @@ This means that if we want an entire section of content
to be given a specific r
TIP: For more
epugh commented on PR #2550:
URL: https://github.com/apache/solr/pull/2550#issuecomment-2210805195
That looks MUCH better! I like the thinner line, with the bold header
This is looking really great.
--
This is an automated message from the Apache Git Service.
To respond to the me
malliaridis commented on PR #2550:
URL: https://github.com/apache/solr/pull/2550#issuecomment-2210796633
I agree, it could be improved. Based on the examples I can update it to look
something like below. Better results can be achieved with a thinner border that
differ a bit from the usual b
epugh commented on PR #2550:
URL: https://github.com/apache/solr/pull/2550#issuecomment-2210706907
Just reran it with the proper settings, thanks... The use of the tabs is
great, it cuts down on the amount of space used...
One nit, I sort of wish it was even clearer they are tabs.
malliaridis commented on PR #2550:
URL: https://github.com/apache/solr/pull/2550#issuecomment-2208596111
> Gave this a quick try, using `gw buildLocalSite` and getting this:
Are you eventually using the nightly UI bundle? Because this is the default
behavior and you need to explicitl
epugh commented on PR #2550:
URL: https://github.com/apache/solr/pull/2550#issuecomment-2208563089
Gave this a quick try, using `gw buildLocalSite` and getting this:
https://github.com/apache/solr/assets/22395/9e6afdd0-4c09-4925-96a6-a640671c85ac";>
--
This is an automated message
malliaridis opened a new pull request, #2550:
URL: https://github.com/apache/solr/pull/2550
https://issues.apache.org/jira/browse/SOLR-16198
# Description
This PR introduces tabbed sections again in the documentation by using
[@asciidoctor/tabs](https://github.com/asciidoctor/a
21 matches
Mail list logo
