janhoy merged PR #1935:
URL: https://github.com/apache/solr/pull/1935
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
epugh commented on PR #1935:
URL: https://github.com/apache/solr/pull/1935#issuecomment-1877166371
I went to check if Ref Guide was updated, and sure enough it was!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
U
janhoy commented on PR #1935:
URL: https://github.com/apache/solr/pull/1935#issuecomment-1876955879
Thanks for the extra review. Will merge to main tomorrow.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL abov
janhoy commented on PR #1935:
URL: https://github.com/apache/solr/pull/1935#issuecomment-1869822343
Could not make the CB tests fail with beasting. So I fully removed all
locking code. We'll soon discover if there are issues.
--
This is an automated message from the Apache Git Service.
To
janhoy commented on PR #1935:
URL: https://github.com/apache/solr/pull/1935#issuecomment-1868940975
Disabled locking and tests pass. I seem to recall that the
GlobalCircuitBreaker tests would break. I’ll try some beasting over Christmas..
--
This is an automated message from the Apache Gi
janhoy commented on code in PR #1935:
URL: https://github.com/apache/solr/pull/1935#discussion_r1435871000
##
solr/core/src/java/org/apache/solr/util/EnvUtils.java:
##
@@ -0,0 +1,279 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor li
dsmiley commented on code in PR #1935:
URL: https://github.com/apache/solr/pull/1935#discussion_r1435763892
##
solr/core/src/java/org/apache/solr/util/EnvUtils.java:
##
@@ -0,0 +1,279 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor l
janhoy commented on PR #1935:
URL: https://github.com/apache/solr/pull/1935#issuecomment-1868368064
@HoustonPutman Thanks to your BATS ssl tests, we caught a problem in this
PR. Needed to exclude all `SOLR_SSL_*` vars from auto conversion to SysProp.
--
This is an automated message from t
janhoy commented on code in PR #1935:
URL: https://github.com/apache/solr/pull/1935#discussion_r1435671275
##
solr/core/src/java/org/apache/solr/util/EnvUtils.java:
##
@@ -0,0 +1,279 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor li
dsmiley commented on code in PR #1935:
URL: https://github.com/apache/solr/pull/1935#discussion_r1435472182
##
solr/core/src/java/org/apache/solr/util/EnvUtils.java:
##
@@ -0,0 +1,279 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor l
janhoy commented on code in PR #1935:
URL: https://github.com/apache/solr/pull/1935#discussion_r1422315202
##
solr/core/src/java/org/apache/solr/util/EnvUtils.java:
##
@@ -0,0 +1,279 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor li
janhoy commented on code in PR #1935:
URL: https://github.com/apache/solr/pull/1935#discussion_r1422119962
##
solr/core/src/java/org/apache/solr/util/EnvUtils.java:
##
@@ -0,0 +1,304 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor li
dsmiley commented on code in PR #1935:
URL: https://github.com/apache/solr/pull/1935#discussion_r1421882174
##
solr/core/src/java/org/apache/solr/util/EnvUtils.java:
##
@@ -0,0 +1,279 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor l
janhoy commented on code in PR #1935:
URL: https://github.com/apache/solr/pull/1935#discussion_r1421572472
##
solr/core/src/java/org/apache/solr/util/EnvUtils.java:
##
@@ -0,0 +1,279 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor li
janhoy commented on PR #1935:
URL: https://github.com/apache/solr/pull/1935#issuecomment-1848442796
In 28400bb72fa4bf06fbf7824b08a79da2ee3b55b1 I removed yet 20 lines from
bin/solr :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
janhoy commented on PR #1935:
URL: https://github.com/apache/solr/pull/1935#issuecomment-1848441008
Thanks for your review @dsmiley and sorry for late response. I updated PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub an
janhoy commented on code in PR #1935:
URL: https://github.com/apache/solr/pull/1935#discussion_r1421435904
##
solr/core/src/java/org/apache/solr/util/EnvUtils.java:
##
@@ -0,0 +1,279 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor li
janhoy commented on code in PR #1935:
URL: https://github.com/apache/solr/pull/1935#discussion_r1421434794
##
solr/core/src/java/org/apache/solr/util/EnvUtils.java:
##
@@ -0,0 +1,279 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor li
janhoy commented on code in PR #1935:
URL: https://github.com/apache/solr/pull/1935#discussion_r1421433610
##
solr/core/src/java/org/apache/solr/util/EnvUtils.java:
##
@@ -0,0 +1,279 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor li
janhoy commented on code in PR #1935:
URL: https://github.com/apache/solr/pull/1935#discussion_r1421432961
##
solr/core/src/java/org/apache/solr/util/EnvUtils.java:
##
@@ -0,0 +1,279 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor li
20 matches
Mail list logo
