pvcnt closed pull request #2016: SOLR-15782: Declare container-level plugins in
solr.xml
URL: https://github.com/apache/solr/pull/2016
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific co
pvcnt commented on PR #2016:
URL: https://github.com/apache/solr/pull/2016#issuecomment-1813958757
Superseded by #2071
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To un
pvcnt commented on code in PR #2016:
URL: https://github.com/apache/solr/pull/2016#discussion_r1363848445
##
solr/solr-ref-guide/modules/configuration-guide/pages/cluster-plugins.adoc:
##
@@ -88,24 +88,22 @@ A JSON map of additional plugin configuration parameters.
Plugins that
pvcnt commented on code in PR #2016:
URL: https://github.com/apache/solr/pull/2016#discussion_r1363845726
##
solr/solr-ref-guide/modules/configuration-guide/pages/cluster-plugins.adoc:
##
@@ -278,3 +276,34 @@ curl -X POST -H 'Content-type: application/json' -d '{
}'
http
pvcnt commented on code in PR #2016:
URL: https://github.com/apache/solr/pull/2016#discussion_r1363843748
##
solr/core/src/test-files/solr/solr-50-all.xml:
##
@@ -52,6 +53,10 @@
DefaultZkCredentialsInjector
+
+value
+
Review Comment:
This is used by `TestS
pvcnt commented on code in PR #2016:
URL: https://github.com/apache/solr/pull/2016#discussion_r1363843267
##
solr/core/src/java/org/apache/solr/core/SolrXmlConfig.java:
##
@@ -659,6 +660,17 @@ private static PluginInfo[]
getBackupRepositoryPluginInfos(List cfg)
return conf
pvcnt commented on code in PR #2016:
URL: https://github.com/apache/solr/pull/2016#discussion_r1363842905
##
solr/core/src/java/org/apache/solr/api/ContainerPluginsRegistry.java:
##
@@ -120,6 +123,33 @@ public void unregisterListener(PluginRegistryListener
listener) {
public
pvcnt commented on code in PR #2016:
URL: https://github.com/apache/solr/pull/2016#discussion_r1363841202
##
solr/core/src/java/org/apache/solr/core/NodeConfig.java:
##
@@ -154,7 +154,7 @@ private NodeConfig(
MetricsConfig metricsConfig,
Map cachesConfig,
Pl
pvcnt commented on code in PR #2016:
URL: https://github.com/apache/solr/pull/2016#discussion_r1363839334
##
solr/solrj/src/java/org/apache/solr/client/solrj/request/beans/PluginMeta.java:
##
@@ -48,6 +48,7 @@ public PluginMeta copy() {
result.name = name;
result.klass
pvcnt commented on code in PR #2016:
URL: https://github.com/apache/solr/pull/2016#discussion_r1363837846
##
solr/core/src/test/org/apache/solr/api/ContainerPluginsRegistryTest.java:
##
@@ -0,0 +1,105 @@
+package org.apache.solr.api;
+
+import java.nio.file.Path;
+import java.ut
dsmiley commented on code in PR #2016:
URL: https://github.com/apache/solr/pull/2016#discussion_r1362721051
##
solr/core/src/java/org/apache/solr/api/ContainerPluginsRegistry.java:
##
@@ -120,6 +123,33 @@ public void unregisterListener(PluginRegistryListener
listener) {
publ
dsmiley commented on PR #2016:
URL: https://github.com/apache/solr/pull/2016#issuecomment-1767106858
> Do we envision having non-cloud container-level plugins, as this PR opens
the way to? I am tempted to say it can be useful, but I don't know the original
intention behind those plugins.
pvcnt commented on code in PR #2016:
URL: https://github.com/apache/solr/pull/2016#discussion_r1362401814
##
solr/core/src/java/org/apache/solr/core/CoreContainer.java:
##
@@ -776,6 +775,7 @@ private void loadInternal() {
ClusterEventProducerFactory clusterEventProducerFact
pvcnt opened a new pull request, #2016:
URL: https://github.com/apache/solr/pull/2016
https://issues.apache.org/jira/browse/SOLR-15782
# Description
Currently, container-level plugins can only be declared installed via calls
to /cluster/plugin APIs. In some situatio
pvcnt commented on code in PR #2016:
URL: https://github.com/apache/solr/pull/2016#discussion_r1360822785
##
solr/solrj/src/java/org/apache/solr/client/solrj/request/beans/PluginMeta.java:
##
@@ -48,6 +48,7 @@ public PluginMeta copy() {
result.name = name;
result.klass
pvcnt commented on code in PR #2016:
URL: https://github.com/apache/solr/pull/2016#discussion_r1360822384
##
solr/core/src/test/org/apache/solr/core/TestSolrXml.java:
##
@@ -78,6 +78,7 @@ public void testAllInfoPresent() throws IOException {
assertEquals("info handler class
pvcnt commented on code in PR #2016:
URL: https://github.com/apache/solr/pull/2016#discussion_r1360821830
##
solr/core/src/test/org/apache/solr/api/ContainerPluginsRegistryTest.java:
##
@@ -0,0 +1,105 @@
+package org.apache.solr.api;
+
+import java.nio.file.Path;
+import java.ut
17 matches
Mail list logo
