Re: [PR] SOLR-14070 : Deprecate CloudSolrClient's ZKHost constructor [solr]

2025-04-05 Thread via GitHub
abumarjikar commented on PR #3298: URL: https://github.com/apache/solr/pull/3298#issuecomment-2768543450 @dsmiley Added changes as per your review. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

Re: [PR] SOLR-14070 : Deprecate CloudSolrClient's ZKHost constructor [solr]

2025-04-01 Thread via GitHub
dsmiley merged PR #3298: URL: https://github.com/apache/solr/pull/3298 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.or

Re: [PR] SOLR-14070 : Deprecate CloudSolrClient's ZKHost constructor [solr]

2025-04-01 Thread via GitHub
dsmiley commented on PR #3298: URL: https://github.com/apache/solr/pull/3298#issuecomment-2771241808 Thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe,

Re: [PR] SOLR-14070 : Deprecate CloudSolrClient's ZKHost constructor [solr]

2025-04-01 Thread via GitHub
abumarjikar commented on code in PR #3298: URL: https://github.com/apache/solr/pull/3298#discussion_r2023981731 ## solr/solr-ref-guide/modules/upgrade-notes/pages/major-changes-in-solr-10.adoc: ## @@ -102,6 +102,8 @@ Users who that don't need to vary JAR access on a per-core ba

Re: [PR] SOLR-14070 : Deprecate CloudSolrClient's ZKHost constructor [solr]

2025-04-01 Thread via GitHub
dsmiley commented on code in PR #3298: URL: https://github.com/apache/solr/pull/3298#discussion_r2023505557 ## solr/solr-ref-guide/modules/upgrade-notes/pages/major-changes-in-solr-10.adoc: ## @@ -102,6 +102,8 @@ Users who that don't need to vary JAR access on a per-core basis

Re: [PR] SOLR-14070 : Deprecate CloudSolrClient's ZKHost constructor [solr]

2025-04-01 Thread via GitHub
dsmiley commented on code in PR #3298: URL: https://github.com/apache/solr/pull/3298#discussion_r2022965033 ## solr/solrj/src/java/org/apache/solr/client/solrj/impl/CloudSolrClient.java: ## Review Comment: JIRA level discussion there -- This is an automated message from

Re: [PR] SOLR-14070 : Deprecate CloudSolrClient's ZKHost constructor [solr]

2025-04-01 Thread via GitHub
epugh commented on code in PR #3298: URL: https://github.com/apache/solr/pull/3298#discussion_r2022372097 ## solr/solrj/src/java/org/apache/solr/client/solrj/impl/CloudSolrClient.java: ## Review Comment: Too bad this can't happen in 9. Or, could it? Deprecate in 9 so we

Re: [PR] SOLR-14070 : Deprecate CloudSolrClient's ZKHost constructor [solr]

2025-03-31 Thread via GitHub
dsmiley commented on PR #3298: URL: https://github.com/apache/solr/pull/3298#issuecomment-2767476095 Nice! `solrj.adoc` needs to be updated. I recommend removing instructions/advise pertaining to the now-deprecated mechanism. Also this deprecation is significant enough to mention

[PR] SOLR-14070 : Deprecate CloudSolrClient's ZKHost constructor [solr]

2025-03-31 Thread via GitHub
abumarjikar opened a new pull request, #3298: URL: https://github.com/apache/solr/pull/3298 https://issues.apache.org/jira/browse/SOLR-14070 # Description This PR will target to deprecate the CloudSolrClient's ZKHost constructor. # Solution This involve