Re: [PR] SOLR-13360: Collation code fails with non-increasing token order [solr]

2024-11-14 Thread via GitHub
github-actions[bot] closed pull request #210: SOLR-13360: Collation code fails with non-increasing token order URL: https://github.com/apache/solr/pull/210 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] SOLR-13360: Collation code fails with non-increasing token order [solr]

2024-11-14 Thread via GitHub
github-actions[bot] commented on PR #210: URL: https://github.com/apache/solr/pull/210#issuecomment-2477657205 This PR is now closed due to 60 days of inactivity after being marked as stale. Re-opening this PR is still possible, in which case it will be marked as active again. -- This i

Re: [PR] SOLR-13360: Collation code fails with non-increasing token order [solr]

2024-09-14 Thread via GitHub
github-actions[bot] commented on PR #210: URL: https://github.com/apache/solr/pull/210#issuecomment-2351231656 This PR has had no activity for 60 days and is now labeled as stale. Any new activity or converting it to draft will remove the stale label. To attract more reviewers, please tag

Re: [PR] SOLR-13360: Collation code fails with non-increasing token order [solr]

2024-07-13 Thread via GitHub
geffchang commented on PR #210: URL: https://github.com/apache/solr/pull/210#issuecomment-2226851356 @epugh Unfortunately, I'm not familiar with this and haven't tried the code either. @rainerjung Any chance you can create a unit test? -- This is an automated message from the Apa

Re: [PR] SOLR-13360: Collation code fails with non-increasing token order [solr]

2024-07-12 Thread via GitHub
epugh commented on PR #210: URL: https://github.com/apache/solr/pull/210#issuecomment-2226779616 @geffchang going back up in the comments, it looks like this needs a unit test. At a minimum we need to have the set of steps for manually reproducing the issue... for me to feel comfortable

Re: [PR] SOLR-13360: Collation code fails with non-increasing token order [solr]

2024-07-12 Thread via GitHub
github-actions[bot] commented on PR #210: URL: https://github.com/apache/solr/pull/210#issuecomment-2226549606 This PR has had no activity for 60 days and is now labeled as stale. Any new activity or converting it to draft will remove the stale label. To attract more reviewers, please tag

Re: [PR] SOLR-13360: Collation code fails with non-increasing token order [solr]

2024-05-06 Thread via GitHub
epugh commented on PR #210: URL: https://github.com/apache/solr/pull/210#issuecomment-2096253924 Looks like the PR needs a test to demonstrate the bug and therefore exercise the fix. These things are hard to evaluate without a unit test. Would you be willing to add one? -- This is an

Re: [PR] SOLR-13360: Collation code fails with non-increasing token order [solr]

2024-05-06 Thread via GitHub
geffchang commented on PR #210: URL: https://github.com/apache/solr/pull/210#issuecomment-2096067466 When is the plan to fix/merge this issue? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

Re: [PR] SOLR-13360: Collation code fails with non-increasing token order [solr]

2024-02-24 Thread via GitHub
github-actions[bot] commented on PR #210: URL: https://github.com/apache/solr/pull/210#issuecomment-1962761431 This PR had no visible activity in the past 60 days, labeling it as stale. Any new activity will remove the stale label. To attract more reviewers, please tag someone or notify the