Re: [PR] SOLR-10998: Obey 'Accept' header in v2 APIs [solr]

2025-03-27 Thread via GitHub
gerlowskija commented on code in PR #3262: URL: https://github.com/apache/solr/pull/3262#discussion_r2006286200 ## solr/core/src/test/org/apache/solr/handler/V2ApiIntegrationTest.java: ## @@ -139,6 +144,52 @@ public void testWTParam() throws Exception { assertEquals(respStr

Re: [PR] SOLR-10998: Obey 'Accept' header in v2 APIs [solr]

2025-03-21 Thread via GitHub
gerlowskija merged PR #3262: URL: https://github.com/apache/solr/pull/3262 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apach

Re: [PR] SOLR-10998: Obey 'Accept' header in v2 APIs [solr]

2025-03-21 Thread via GitHub
gerlowskija commented on PR #3262: URL: https://github.com/apache/solr/pull/3262#issuecomment-2743348019 > In SolrJ, assuming "V2", how might we compose an Accept header for multiple formats, and then on the receiving end, choose the right ResponseParser for the final format chosen by the s

Re: [PR] SOLR-10998: Obey 'Accept' header in v2 APIs [solr]

2025-03-20 Thread via GitHub
gerlowskija commented on code in PR #3262: URL: https://github.com/apache/solr/pull/3262#discussion_r2006286200 ## solr/core/src/test/org/apache/solr/handler/V2ApiIntegrationTest.java: ## @@ -139,6 +144,52 @@ public void testWTParam() throws Exception { assertEquals(respStr

Re: [PR] SOLR-10998: Obey 'Accept' header in v2 APIs [solr]

2025-03-20 Thread via GitHub
gerlowskija commented on code in PR #3262: URL: https://github.com/apache/solr/pull/3262#discussion_r2006286200 ## solr/core/src/test/org/apache/solr/handler/V2ApiIntegrationTest.java: ## @@ -139,6 +144,52 @@ public void testWTParam() throws Exception { assertEquals(respStr

Re: [PR] SOLR-10998: Obey 'Accept' header in v2 APIs [solr]

2025-03-20 Thread via GitHub
gerlowskija commented on code in PR #3262: URL: https://github.com/apache/solr/pull/3262#discussion_r2006286200 ## solr/core/src/test/org/apache/solr/handler/V2ApiIntegrationTest.java: ## @@ -139,6 +144,52 @@ public void testWTParam() throws Exception { assertEquals(respStr

Re: [PR] SOLR-10998: Obey 'Accept' header in v2 APIs [solr]

2025-03-17 Thread via GitHub
dsmiley commented on code in PR #3262: URL: https://github.com/apache/solr/pull/3262#discussion_r1999537597 ## solr/core/src/test/org/apache/solr/handler/V2ApiIntegrationTest.java: ## @@ -139,6 +144,52 @@ public void testWTParam() throws Exception { assertEquals(respString,

Re: [PR] SOLR-10998: Obey 'Accept' header in v2 APIs [solr]

2025-03-17 Thread via GitHub
gerlowskija commented on PR #3262: URL: https://github.com/apache/solr/pull/3262#issuecomment-2729650633 > a test would be nice Tests added in `V2ApiIntegrationTest` > It's a mystery to me how this PR accomplishes that goal. Really it doesn't. Jersey will parse the "Acce

Re: [PR] SOLR-10998: Obey 'Accept' header in v2 APIs [solr]

2025-03-15 Thread via GitHub
dsmiley commented on PR #3262: URL: https://github.com/apache/solr/pull/3262#issuecomment-2726984646 I love what you wrote -- what this PR accomplishes. It's a mystery to me **how** this PR accomplishes that goal. A test would be nice. -- This is an automated message from the Apache Git

Re: [PR] SOLR-10998: Obey 'Accept' header in v2 APIs [solr]

2025-03-13 Thread via GitHub
epugh commented on PR #3262: URL: https://github.com/apache/solr/pull/3262#issuecomment-2720940030 This is some nice alignment with normal web expectations.. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[PR] SOLR-10998: Obey 'Accept' header in v2 APIs [solr]

2025-03-13 Thread via GitHub
gerlowskija opened a new pull request, #3262: URL: https://github.com/apache/solr/pull/3262 'wt' takes precedence if specified for now, if not provided Solr (through our use of Jersey) will pick a response format in keeping with the specified 'Accept' header. JSON responses remains t