mkhludnev commented on code in PR #2078:
URL: https://github.com/apache/solr/pull/2078#discussion_r1397079515
##
solr/modules/extraction/src/test/org/apache/solr/handler/extraction/TestXLSXResponseWriter.java:
##
@@ -38,8 +38,10 @@
import org.apache.solr.search.SolrReturnFields
mkhludnev commented on code in PR #2078:
URL: https://github.com/apache/solr/pull/2078#discussion_r1397077252
##
solr/core/src/test/org/apache/solr/update/UuidAtomicUpdateTest.java:
##
@@ -0,0 +1,155 @@
+package org.apache.solr.update;
+
+import java.util.Collection;
+import jav
mkhludnev commented on code in PR #2078:
URL: https://github.com/apache/solr/pull/2078#discussion_r1397077252
##
solr/core/src/test/org/apache/solr/update/UuidAtomicUpdateTest.java:
##
@@ -0,0 +1,155 @@
+package org.apache.solr.update;
+
+import java.util.Collection;
+import jav
mkhludnev commented on code in PR #2078:
URL: https://github.com/apache/solr/pull/2078#discussion_r1397076453
##
solr/core/src/java/org/apache/solr/schema/FieldType.java:
##
@@ -301,6 +301,8 @@ public IndexableField createField(SchemaField field, Object
value) {
String val
mkhludnev commented on code in PR #2078:
URL: https://github.com/apache/solr/pull/2078#discussion_r1397075415
##
solr/core/src/java/org/apache/solr/schema/UUIDField.java:
##
@@ -92,17 +92,4 @@ public String toInternal(String val) {
public String toInternal(UUID uuid) {
r
mkhludnev commented on PR #2078:
URL: https://github.com/apache/solr/pull/2078#issuecomment-1816136352
I removed both of UUID instantiation cases since javabin have no type tag
for UUID.
It can be introduced in a separate ticket for sake of performance.
--
This is an automated messag
dsmiley commented on code in PR #2078:
URL: https://github.com/apache/solr/pull/2078#discussion_r1396509277
##
solr/core/src/test/org/apache/solr/update/UUIDAtomicUpdateTest.java:
##
@@ -0,0 +1,153 @@
+package org.apache.solr.update;
+
+import java.util.Collection;
+import java.
mkhludnev commented on PR #2078:
URL: https://github.com/apache/solr/pull/2078#issuecomment-1815296178
It fails when we have leader and replica, when committed document is
updated, leader updates a replica
`Remote error message: ERROR: [doc=1] Error adding field
'uuid'='java.util.UUID:fb
mkhludnev commented on PR #2078:
URL: https://github.com/apache/solr/pull/2078#issuecomment-1814389729
UUIDField throws `BAD_REQUEST` but in log I see `o.a.s.s.HttpSolrCall 500
Exception`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log
