dsmiley merged PR #2536:
URL: https://github.com/apache/solr/pull/2536
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.or
serba commented on PR #2536:
URL: https://github.com/apache/solr/pull/2536#issuecomment-2233699262
@dsmiley @mkhludnev Could you please guys merge this MR if you think it is
ready? I don't have write access. Thank you!
--
This is an automated message from the Apache Git Service.
To respon
serba commented on code in PR #2536:
URL: https://github.com/apache/solr/pull/2536#discussion_r1673451696
##
solr/core/src/test-files/solr/collection1/conf/bad-schema-unsupported-docValues.xml:
##
Review Comment:
I think this test is not testing binary doc values per say, b
serba commented on code in PR #2536:
URL: https://github.com/apache/solr/pull/2536#discussion_r1673447557
##
solr/core/src/java/org/apache/solr/schema/BinaryField.java:
##
@@ -112,7 +125,31 @@ public IndexableField createField(SchemaField field,
Object val) {
len = buf.l
mkhludnev commented on code in PR #2536:
URL: https://github.com/apache/solr/pull/2536#discussion_r1670638010
##
solr/core/src/java/org/apache/solr/schema/BinaryField.java:
##
@@ -112,7 +125,31 @@ public IndexableField createField(SchemaField field,
Object val) {
len = b
mkhludnev commented on code in PR #2536:
URL: https://github.com/apache/solr/pull/2536#discussion_r1670638010
##
solr/core/src/java/org/apache/solr/schema/BinaryField.java:
##
@@ -112,7 +125,31 @@ public IndexableField createField(SchemaField field,
Object val) {
len = b
