Re: [PR] Review SolrJ code for typos [solr]

2024-08-23 Thread via GitHub
epugh merged PR #2656: URL: https://github.com/apache/solr/pull/2656 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org

Re: [PR] Review SolrJ code for typos [solr]

2024-08-23 Thread via GitHub
epugh commented on code in PR #2656: URL: https://github.com/apache/solr/pull/2656#discussion_r1728881870 ## solr/solrj/src/java/org/apache/solr/client/solrj/impl/HttpSolrClientBase.java: ## @@ -121,7 +121,7 @@ protected ResponseParser responseParser(SolrRequest solrRequest) {

Re: [PR] Review SolrJ code for typos [solr]

2024-08-22 Thread via GitHub
epugh commented on code in PR #2656: URL: https://github.com/apache/solr/pull/2656#discussion_r1727644003 ## solr/solrj/src/java/org/apache/solr/client/solrj/impl/HttpSolrClientBase.java: ## @@ -121,7 +121,7 @@ protected ResponseParser responseParser(SolrRequest solrRequest) {

Re: [PR] Review SolrJ code for typos [solr]

2024-08-22 Thread via GitHub
epugh commented on PR #2656: URL: https://github.com/apache/solr/pull/2656#issuecomment-2304798584 Stuck in an airport on 5 hours of sleep and my brain was too dead to do anything more than mindless mousing and clicking! -- This is an automated message from the Apache Git Service. To resp

Re: [PR] Review SolrJ code for typos [solr]

2024-08-22 Thread via GitHub
epugh commented on code in PR #2656: URL: https://github.com/apache/solr/pull/2656#discussion_r1727154578 ## solr/solrj/src/java/org/apache/solr/client/solrj/impl/HttpSolrClientBase.java: ## @@ -121,7 +121,7 @@ protected ResponseParser responseParser(SolrRequest solrRequest) {

Re: [PR] Review SolrJ code for typos [solr]

2024-08-22 Thread via GitHub
janhoy commented on code in PR #2656: URL: https://github.com/apache/solr/pull/2656#discussion_r1727104183 ## solr/solrj/src/java/org/apache/solr/client/solrj/impl/HttpSolrClientBase.java: ## @@ -121,7 +121,7 @@ protected ResponseParser responseParser(SolrRequest solrRequest) {

Re: [PR] Review SolrJ code for typos [solr]

2024-08-22 Thread via GitHub
janhoy commented on code in PR #2656: URL: https://github.com/apache/solr/pull/2656#discussion_r1727104183 ## solr/solrj/src/java/org/apache/solr/client/solrj/impl/HttpSolrClientBase.java: ## @@ -121,7 +121,7 @@ protected ResponseParser responseParser(SolrRequest solrRequest) {

Re: [PR] Review SolrJ code for typos [solr]

2024-08-22 Thread via GitHub
epugh commented on PR #2656: URL: https://github.com/apache/solr/pull/2656#issuecomment-2304324350 Anyone want to review 132 files ;-) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific