Re: [PR] Removing list.toArray calls with pre sized arrays [solr]

2023-10-12 Thread via GitHub
renatoh commented on PR #2003: URL: https://github.com/apache/solr/pull/2003#issuecomment-1759679190 @risdenk yes, since I only cleaned them up in the module solr/core -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use th

Re: [PR] Removing list.toArray calls with pre sized arrays [solr]

2023-10-12 Thread via GitHub
risdenk commented on PR #2003: URL: https://github.com/apache/solr/pull/2003#issuecomment-1759655586 @renatoh on your branch - I see that there are still ~54 outstanding toArray with sizes according to intellij? Is that expected? -- This is an automated message from the Apache Git Service

Re: [PR] Removing list.toArray calls with pre sized arrays [solr]

2023-10-12 Thread via GitHub
renatoh commented on PR #2003: URL: https://github.com/apache/solr/pull/2003#issuecomment-1759635212 @risdenk thanks for review my PR, are you able to merge the PR? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

Re: [PR] Removing List.toArray calls with pre-sized Arrays [solr]

2023-10-11 Thread via GitHub
renatoh closed pull request #1873: Removing List.toArray calls with pre-sized Arrays URL: https://github.com/apache/solr/pull/1873 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific commen